2023-08-03 20:27:52

by Lucas Karpinski

Subject: [PATCH v3] selftests: cgroup: fix test_kmem_basic slab1 check

test_kmem_basic creates 100,000 negative dentries, with each one mapping
to a slab object. After memory.high is set, these are reclaimed through
the shrink_slab function call which reclaims all 100,000 entries. The
test passes the majority of the time because when slab1 is calculated,
it is often above 0, however, 0 is also an acceptable value.

Signed-off-by: Lucas Karpinski <[email protected]>
---
v3: rebased on mm-unstable

tools/testing/selftests/cgroup/test_kmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/cgroup/test_kmem.c b/tools/testing/selftests/cgroup/test_kmem.c
index 1b2cec9d18a4..67cc0182058d 100644
--- a/tools/testing/selftests/cgroup/test_kmem.c
+++ b/tools/testing/selftests/cgroup/test_kmem.c
@@ -75,7 +75,7 @@ static int test_kmem_basic(const char *root)
sleep(1);

slab1 = cg_read_key_long(cg, "memory.stat", "slab ");
- if (slab1 <= 0)
+ if (slab1 < 0)
goto cleanup;

current = cg_read_long(cg, "memory.current");
--
2.41.0

2023-08-04 07:39:42

by Muchun Song

Subject: Re: [PATCH v3] selftests: cgroup: fix test_kmem_basic slab1 check

> On Aug 4, 2023, at 02:25, Lucas Karpinski <[email protected]> wrote:
>
> test_kmem_basic creates 100,000 negative dentries, with each one mapping
> to a slab object. After memory.high is set, these are reclaimed through
> the shrink_slab function call which reclaims all 100,000 entries. The
> test passes the majority of the time because when slab1 is calculated,
> it is often above 0, however, 0 is also an acceptable value.
>
> Signed-off-by: Lucas Karpinski <[email protected]>

Reviewed-by: Muchun Song <[email protected]>

Thanks