2013-04-07 16:57:38

by Zhihui Zhang

[permalink] [raw]

Subject: [PATCH] F2FS: Fix the logic of IS_DNODE()

---

Signed-off-by: Zhihui Zhang <[email protected]>
---
fs/f2fs/node.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h
index afdb130..2be47b2 100644
--- a/fs/f2fs/node.h
+++ b/fs/f2fs/node.h
@@ -239,7 +239,7 @@ static inline bool IS_DNODE(struct page *node_page)
return false;
if (ofs >= 6 + 2 * NIDS_PER_BLOCK) {
ofs -= 6 + 2 * NIDS_PER_BLOCK;
- if ((long int)ofs % (NIDS_PER_BLOCK + 1))
+ if (!((long int)ofs % (NIDS_PER_BLOCK + 1)))
return false;
}
return true;
--
1.7.9.5

2013-04-08 06:19:00

by Jaegeuk Kim

[permalink] [raw]

Subject: Re: [PATCH] F2FS: Fix the logic of IS_DNODE()

---

Hi,

2013-04-07 (일), 12:57 -0400, Zhihui Zhang:
> Signed-off-by: Zhihui Zhang <[email protected]>
> ---
> fs/f2fs/node.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h
> index afdb130..2be47b2 100644
> --- a/fs/f2fs/node.h
> +++ b/fs/f2fs/node.h
> @@ -239,7 +239,7 @@ static inline bool IS_DNODE(struct page *node_page)
> return false;
> if (ofs >= 6 + 2 * NIDS_PER_BLOCK) {
> ofs -= 6 + 2 * NIDS_PER_BLOCK;
> - if ((long int)ofs % (NIDS_PER_BLOCK + 1))
> + if (!((long int)ofs % (NIDS_PER_BLOCK + 1)))

Great catch!
I'll apply this.
Thank you.

> return false;
> }
> return true;

--
Jaegeuk Kim
Samsung

---

Attachments:

signature.asc (836.00 B)
This is a digitally signed message part