From: Xiong Zhou <[email protected]>
Fix randconfig build failure for Amilo x86 platform driver.
AMILO_RFKILL requires SERIO_I8042 being available.
amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
Reported-by: Jim Davis <[email protected]>
Signed-off-by: Xiong Zhou <[email protected]>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 8577261..37645b9 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -176,6 +176,7 @@ config FUJITSU_TABLET
config AMILO_RFKILL
tristate "Fujitsu-Siemens Amilo rfkill support"
depends on RFKILL
+ depends on SERIO_I8042
---help---
This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
laptops.
On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote:
> From: Xiong Zhou <[email protected]>
>
> Fix randconfig build failure for Amilo x86 platform driver.
> AMILO_RFKILL requires SERIO_I8042 being available.
>
> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
>
> Reported-by: Jim Davis <[email protected]>
> Signed-off-by: Xiong Zhou <[email protected]>
Acked-by: Ben Hutchings <[email protected]>
But I thought somehow sent this same fix a while back...
Ben.
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 8577261..37645b9 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -176,6 +176,7 @@ config FUJITSU_TABLET
> config AMILO_RFKILL
> tristate "Fujitsu-Siemens Amilo rfkill support"
> depends on RFKILL
> + depends on SERIO_I8042
> ---help---
> This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
> laptops.
--
Ben Hutchings
Humans are not rational beings; they are rationalising beings.
On 06/18/13 06:04, Ben Hutchings wrote:
> On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote:
>> From: Xiong Zhou <[email protected]>
>>
>> Fix randconfig build failure for Amilo x86 platform driver.
>> AMILO_RFKILL requires SERIO_I8042 being available.
>>
>> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
>> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
>> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
>>
>> Reported-by: Jim Davis <[email protected]>
>> Signed-off-by: Xiong Zhou <[email protected]>
>
> Acked-by: Ben Hutchings <[email protected]>
>
> But I thought somehow sent this same fix a while back...
Yes, I reported it and sent a patch for it that you acked...
I guess my patch was never picked up.
>
> Ben.
>
>> ---
>> drivers/platform/x86/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>> index 8577261..37645b9 100644
>> --- a/drivers/platform/x86/Kconfig
>> +++ b/drivers/platform/x86/Kconfig
>> @@ -176,6 +176,7 @@ config FUJITSU_TABLET
>> config AMILO_RFKILL
>> tristate "Fujitsu-Siemens Amilo rfkill support"
>> depends on RFKILL
>> + depends on SERIO_I8042
>> ---help---
>> This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
>> laptops.
>
--
~Randy
2013/6/18 Randy Dunlap <[email protected]>:
> On 06/18/13 06:04, Ben Hutchings wrote:
>> On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote:
>>> From: Xiong Zhou <[email protected]>
>>>
>>> Fix randconfig build failure for Amilo x86 platform driver.
>>> AMILO_RFKILL requires SERIO_I8042 being available.
>>>
>>> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
>>> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
>>> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
>>>
>>> Reported-by: Jim Davis <[email protected]>
>>> Signed-off-by: Xiong Zhou <[email protected]>
>>
>> Acked-by: Ben Hutchings <[email protected]>
>>
>> But I thought somehow sent this same fix a while back...
>
> Yes, I reported it and sent a patch for it that you acked...
> I guess my patch was never picked up.
>
... Better someone pick this up.
>>
>> Ben.
>>
>>> ---
>>> drivers/platform/x86/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>>> index 8577261..37645b9 100644
>>> --- a/drivers/platform/x86/Kconfig
>>> +++ b/drivers/platform/x86/Kconfig
>>> @@ -176,6 +176,7 @@ config FUJITSU_TABLET
>>> config AMILO_RFKILL
>>> tristate "Fujitsu-Siemens Amilo rfkill support"
>>> depends on RFKILL
>>> + depends on SERIO_I8042
>>> ---help---
>>> This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
>>> laptops.
>>
>
>
> --
> ~Randy
On 06/18/13 18:09, Xiong Zhou wrote:
> 2013/6/18 Randy Dunlap <[email protected]>:
>> On 06/18/13 06:04, Ben Hutchings wrote:
>>> On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote:
>>>> From: Xiong Zhou <[email protected]>
>>>>
>>>> Fix randconfig build failure for Amilo x86 platform driver.
>>>> AMILO_RFKILL requires SERIO_I8042 being available.
>>>>
>>>> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
>>>> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
>>>> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
>>>>
>>>> Reported-by: Jim Davis <[email protected]>
>>>> Signed-off-by: Xiong Zhou <[email protected]>
>>>
>>> Acked-by: Ben Hutchings <[email protected]>
>>>
>>> But I thought somehow sent this same fix a while back...
>>
>> Yes, I reported it and sent a patch for it that you acked...
>> I guess my patch was never picked up.
>>
>
> ... Better someone pick this up.
>
This build error is still occurring in linux-next (20130627).
I first reported it and posted a patch for it on May-15 2013.
Please merge either patch...
Is anybody out there?
>
>>>
>>> Ben.
>>>
>>>> ---
>>>> drivers/platform/x86/Kconfig | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>>>> index 8577261..37645b9 100644
>>>> --- a/drivers/platform/x86/Kconfig
>>>> +++ b/drivers/platform/x86/Kconfig
>>>> @@ -176,6 +176,7 @@ config FUJITSU_TABLET
>>>> config AMILO_RFKILL
>>>> tristate "Fujitsu-Siemens Amilo rfkill support"
>>>> depends on RFKILL
>>>> + depends on SERIO_I8042
>>>> ---help---
>>>> This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
>>>> laptops.
>>>
>>
>>
>> --
>> ~Randy
> --
--
~Randy
2013/6/28 Randy Dunlap <[email protected]>:
> On 06/18/13 18:09, Xiong Zhou wrote:
>> 2013/6/18 Randy Dunlap <[email protected]>:
>>> On 06/18/13 06:04, Ben Hutchings wrote:
>>>> On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote:
>>>>> From: Xiong Zhou <[email protected]>
>>>>>
>>>>> Fix randconfig build failure for Amilo x86 platform driver.
>>>>> AMILO_RFKILL requires SERIO_I8042 being available.
>>>>>
>>>>> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
>>>>> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
>>>>> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
>>>>>
>>>>> Reported-by: Jim Davis <[email protected]>
>>>>> Signed-off-by: Xiong Zhou <[email protected]>
>>>>
>>>> Acked-by: Ben Hutchings <[email protected]>
>>>>
>>>> But I thought somehow sent this same fix a while back...
>>>
>>> Yes, I reported it and sent a patch for it that you acked...
>>> I guess my patch was never picked up.
>>>
>>
>> ... Better someone pick this up.
>>
>
> This build error is still occurring in linux-next (20130627).
> I first reported it and posted a patch for it on May-15 2013.
>
> Please merge either patch...
>
> Is anybody out there?
>
>
>>
>>>>
>>>> Ben.
>>>>
>>>>> ---
>>>>> drivers/platform/x86/Kconfig | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>>>>> index 8577261..37645b9 100644
>>>>> --- a/drivers/platform/x86/Kconfig
>>>>> +++ b/drivers/platform/x86/Kconfig
>>>>> @@ -176,6 +176,7 @@ config FUJITSU_TABLET
>>>>> config AMILO_RFKILL
>>>>> tristate "Fujitsu-Siemens Amilo rfkill support"
>>>>> depends on RFKILL
>>>>> + depends on SERIO_I8042
>>>>> ---help---
>>>>> This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
>>>>> laptops.
>>>>
>>>
>>>
>>> --
>>> ~Randy
>> --
>
>
> --
> ~Randy
cc Jiri Kosina <[email protected]>
On Fri, 12 Jul 2013, Xiong Zhou wrote:
> >>>>> Fix randconfig build failure for Amilo x86 platform driver.
> >>>>> AMILO_RFKILL requires SERIO_I8042 being available.
> >>>>>
> >>>>> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
> >>>>> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
> >>>>> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
> >>>>>
> >>>>> Reported-by: Jim Davis <[email protected]>
> >>>>> Signed-off-by: Xiong Zhou <[email protected]>
> >>>>
> >>>> Acked-by: Ben Hutchings <[email protected]>
> >>>>
> >>>> But I thought somehow sent this same fix a while back...
> >>>
> >>> Yes, I reported it and sent a patch for it that you acked...
> >>> I guess my patch was never picked up.
> >>>
> >>
> >> ... Better someone pick this up.
> >>
> >
> > This build error is still occurring in linux-next (20130627).
> > I first reported it and posted a patch for it on May-15 2013.
> >
> > Please merge either patch...
> >
> > Is anybody out there?
> >
> >
> >>
> >>>>
> >>>> Ben.
> >>>>
> >>>>> ---
> >>>>> drivers/platform/x86/Kconfig | 1 +
> >>>>> 1 file changed, 1 insertion(+)
> >>>>>
> >>>>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> >>>>> index 8577261..37645b9 100644
> >>>>> --- a/drivers/platform/x86/Kconfig
> >>>>> +++ b/drivers/platform/x86/Kconfig
> >>>>> @@ -176,6 +176,7 @@ config FUJITSU_TABLET
> >>>>> config AMILO_RFKILL
> >>>>> tristate "Fujitsu-Siemens Amilo rfkill support"
> >>>>> depends on RFKILL
> >>>>> + depends on SERIO_I8042
> >>>>> ---help---
> >>>>> This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
> >>>>> laptops.
> >>>>
> >>>
> >>>
> >>> --
> >>> ~Randy
> >> --
> >
> >
> > --
> > ~Randy
>
>
>
> cc Jiri Kosina <[email protected]>
Please resend the patch properly, it's not easy to dig it from the
multi-depth quoted text.
--
Jiri Kosina
SUSE Labs