2015-02-04 12:04:22

by Lad, Prabhakar

Subject: [PATCH] of/fdt: fix sparse warning

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:

fdt.c:765:12: warning: symbol 'early_init_dt_scan_chosen_serial' was not declared. Should it be static?

Signed-off-by: Lad, Prabhakar <[email protected]>
---
Found this issue on linux-next and applies on top linux-next.

drivers/of/fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 5100742..3a896c9 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -762,7 +762,7 @@ static inline void early_init_dt_check_for_initrd(unsigned long node)
#ifdef CONFIG_SERIAL_EARLYCON
extern struct of_device_id __earlycon_of_table[];

-int __init early_init_dt_scan_chosen_serial(void)
+static int __init early_init_dt_scan_chosen_serial(void)
{
int offset;
const char *p;
--
1.9.1

2015-02-04 16:01:50

by Rob Herring

Subject: Re: [PATCH] of/fdt: fix sparse warning

On Wed, Feb 4, 2015 at 6:04 AM, Lad Prabhakar
<[email protected]> wrote:
> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warning:
>
> fdt.c:765:12: warning: symbol 'early_init_dt_scan_chosen_serial' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <[email protected]>

Applied, thanks.

Rob

> ---
> Found this issue on linux-next and applies on top linux-next.
>
> drivers/of/fdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 5100742..3a896c9 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -762,7 +762,7 @@ static inline void early_init_dt_check_for_initrd(unsigned long node)
> #ifdef CONFIG_SERIAL_EARLYCON
> extern struct of_device_id __earlycon_of_table[];
>
> -int __init early_init_dt_scan_chosen_serial(void)
> +static int __init early_init_dt_scan_chosen_serial(void)
> {
> int offset;
> const char *p;
> --
> 1.9.1
>