2015-04-20 21:43:40

by Vivien Didelot

Subject: [PATCH] net: dsa: mv88e6xxx: use PORT_DEFAULT_VLAN

Minor, use the explicit PORT_DEFAULT_VLAN define instead of 0x07.

Signed-off-by: Vivien Didelot <[email protected]>
---
drivers/net/dsa/mv88e6xxx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index 48712bd..af639ab 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -1274,7 +1274,8 @@ int mv88e6xxx_setup_port_common(struct dsa_switch *ds, int port)
/* Default VLAN ID and priority: don't set a default VLAN
* ID, and set the default packet priority to zero.
*/
- ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), 0x07, 0x0000);
+ ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), PORT_DEFAULT_VLAN,
+ 0x0000);
abort:
mutex_unlock(&ps->smi_mutex);
return ret;
--
2.3.5

2015-04-20 23:04:54

by Andrew Lunn

Subject: Re: [PATCH] net: dsa: mv88e6xxx: use PORT_DEFAULT_VLAN

On Mon, Apr 20, 2015 at 05:43:26PM -0400, Vivien Didelot wrote:
> Minor, use the explicit PORT_DEFAULT_VLAN define instead of 0x07.

Hi Vivien

I would not normally use the word "Minor" here, since it will end up
in the commit log.

Other than that:

Acked-by: Andrew Lunn <[email protected]>

Thanks
Andrew

>
> Signed-off-by: Vivien Didelot <[email protected]>
> ---
> drivers/net/dsa/mv88e6xxx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
> index 48712bd..af639ab 100644
> --- a/drivers/net/dsa/mv88e6xxx.c
> +++ b/drivers/net/dsa/mv88e6xxx.c
> @@ -1274,7 +1274,8 @@ int mv88e6xxx_setup_port_common(struct dsa_switch *ds, int port)
> /* Default VLAN ID and priority: don't set a default VLAN
> * ID, and set the default packet priority to zero.
> */
> - ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), 0x07, 0x0000);
> + ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), PORT_DEFAULT_VLAN,
> + 0x0000);
> abort:
> mutex_unlock(&ps->smi_mutex);
> return ret;
> --
> 2.3.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2015-04-21 02:02:08

by David Miller

Subject: Re: [PATCH] net: dsa: mv88e6xxx: use PORT_DEFAULT_VLAN

From: Vivien Didelot <[email protected]>
Date: Mon, 20 Apr 2015 17:43:26 -0400

> Minor, use the explicit PORT_DEFAULT_VLAN define instead of 0x07.
>
> Signed-off-by: Vivien Didelot <[email protected]>

Applied.