2015-06-01 15:10:11

by Valentin Rothberg

[permalink] [raw]
Subject: watchdog: st_wdt: select on undefined MFD_ST_LPC

Hi Lee,

your commit d0c9e350b9a4 ("watchdog: st_wdt: Add new driver for ST's
LPC Watchdog") is in today's linux-next tree (i.e., next-20150601) and
adds the following lines of code to drivers/watchdog/Kconfig.

+config ST_LPC_WATCHDOG
...
+ select MFD_ST_LPC

The select turns out to be a NOOP since MFD_ST_LPC is not defined
Kconfig. Is it the correct option to be selected? I could not find a
similar option in the source, nor get any hints from searching the
lkml.

I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
the last and today's linux tree.

Kind regards,
Valentin


2015-06-01 17:55:24

by Lee Jones

[permalink] [raw]
Subject: Re: watchdog: st_wdt: select on undefined MFD_ST_LPC

On Mon, 01 Jun 2015, Valentin Rothberg wrote:

> Hi Lee,
>
> your commit d0c9e350b9a4 ("watchdog: st_wdt: Add new driver for ST's
> LPC Watchdog") is in today's linux-next tree (i.e., next-20150601) and
> adds the following lines of code to drivers/watchdog/Kconfig.
>
> +config ST_LPC_WATCHDOG
> ...
> + select MFD_ST_LPC
>
> The select turns out to be a NOOP since MFD_ST_LPC is not defined
> Kconfig. Is it the correct option to be selected? I could not find a
> similar option in the source, nor get any hints from searching the
> lkml.
>
> I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
> the last and today's linux tree.

You're right. This symbol is legacy. I will remove.

Thanks for reporting.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog