2015-08-08 09:25:00

by Tomer Barletz

Subject: [PATCH] tty: Fix potentialy used uninitialized variable

Initialize size to 0, as it may be used uninitialized in case
read_mem32() fails.

Signed-off-by: Tomer Barletz <[email protected]>
---
drivers/tty/nozomi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
index 80f9de9..d70e9e4 100644
--- a/drivers/tty/nozomi.c
+++ b/drivers/tty/nozomi.c
@@ -816,7 +816,7 @@ static int send_data(enum port_type index, struct nozomi *dc)
static int receive_data(enum port_type index, struct nozomi *dc)
{
u8 buf[RECEIVE_BUF_MAX] = { 0 };
- int size;
+ int size = 0;
u32 offset = 4;
struct port *port = &dc->port[index];
void __iomem *addr = port->dl_addr[port->toggle_dl];
--
2.4.3

2015-08-08 09:37:29

by Richard Weinberger

Subject: Re: [PATCH] tty: Fix potentialy used uninitialized variable

On Sat, Aug 8, 2015 at 11:24 AM, Tomer Barletz <[email protected]> wrote:
> Initialize size to 0, as it may be used uninitialized in case
> read_mem32() fails.

Instead of papering over the issue better cleanup read_mem32() such that
a failure can be detected. :-)

--
Thanks,
//richard