2015-12-02 11:27:37

by Wenwei Tao

Subject: [PATCH] lightnvm: use flags as input parameter

rrpc_get_blk use constant 0 as the input parameter
of nvm_get_blk, this may result in getting gc block
failed unexpectedly.

Signed-off-by: Wenwei Tao <[email protected]>
---
drivers/lightnvm/rrpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
index 75e59c3..d606c7a 100644
--- a/drivers/lightnvm/rrpc.c
+++ b/drivers/lightnvm/rrpc.c
@@ -182,7 +182,7 @@ static struct rrpc_block *rrpc_get_blk(struct rrpc *rrpc, struct rrpc_lun *rlun,
struct nvm_block *blk;
struct rrpc_block *rblk;

- blk = nvm_get_blk(rrpc->dev, rlun->parent, 0);
+ blk = nvm_get_blk(rrpc->dev, rlun->parent, flags);
if (!blk)
return NULL;

--
1.8.3.1

2015-12-02 11:35:58

by Matias Bjørling

Subject: Re: [PATCH] lightnvm: use flags as input parameter

On 12/02/2015 12:25 PM, Wenwei Tao wrote:
> rrpc_get_blk use constant 0 as the input parameter
> of nvm_get_blk, this may result in getting gc block
> failed unexpectedly.
>
> Signed-off-by: Wenwei Tao <[email protected]>
> ---
> drivers/lightnvm/rrpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
> index 75e59c3..d606c7a 100644
> --- a/drivers/lightnvm/rrpc.c
> +++ b/drivers/lightnvm/rrpc.c
> @@ -182,7 +182,7 @@ static struct rrpc_block *rrpc_get_blk(struct rrpc *rrpc, struct rrpc_lun *rlun,
> struct nvm_block *blk;
> struct rrpc_block *rblk;
>
> - blk = nvm_get_blk(rrpc->dev, rlun->parent, 0);
> + blk = nvm_get_blk(rrpc->dev, rlun->parent, flags);
> if (!blk)
> return NULL;
>
>

Thanks Tao, applied.