2015-12-06 19:49:33

by Saurabh Sengar

Subject: [PATCH] drm: msm: dsi: Added missing mutex_unlock

in case of failed to get iova, function was returning without releasing
the mutex. Added it.

Signed-off-by: Saurabh Sengar <[email protected]>
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 4c49868..13f937b 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -849,11 +849,11 @@ static int dsi_tx_buf_alloc(struct msm_dsi_host *msm_host, int size)
}

ret = msm_gem_get_iova_locked(msm_host->tx_gem_obj, 0, &iova);
+ mutex_unlock(&dev->struct_mutex);
if (ret) {
pr_err("%s: failed to get iova, %d\n", __func__, ret);
return ret;
}
- mutex_unlock(&dev->struct_mutex);

if (iova & 0x07) {
pr_err("%s: buf NOT 8 bytes aligned\n", __func__);
--
1.9.1

2015-12-07 16:55:58

by Rob Clark

Subject: Re: [PATCH] drm: msm: dsi: Added missing mutex_unlock

On Sun, Dec 6, 2015 at 2:49 PM, Saurabh Sengar <[email protected]> wrote:
> in case of failed to get iova, function was returning without releasing
> the mutex. Added it.
>
> Signed-off-by: Saurabh Sengar <[email protected]>

Reviewed-by: Rob Clark <[email protected]>

> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 4c49868..13f937b 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -849,11 +849,11 @@ static int dsi_tx_buf_alloc(struct msm_dsi_host *msm_host, int size)
> }
>
> ret = msm_gem_get_iova_locked(msm_host->tx_gem_obj, 0, &iova);
> + mutex_unlock(&dev->struct_mutex);
> if (ret) {
> pr_err("%s: failed to get iova, %d\n", __func__, ret);
> return ret;
> }
> - mutex_unlock(&dev->struct_mutex);
>
> if (iova & 0x07) {
> pr_err("%s: buf NOT 8 bytes aligned\n", __func__);
> --
> 1.9.1
>