2016-04-10 19:22:45

by Ksenija Stanojevic

Subject: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT

Set INPUT_PROP_DIRECT to indicate that it is a touchscreen on the
device to help userspace classify it.

Signed-off-by: Ksenija Stanojevic <[email protected]>
---
drivers/iio/adc/mxs-lradc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c
index 07287af..e4c4c5c 100644
--- a/drivers/iio/adc/mxs-lradc.c
+++ b/drivers/iio/adc/mxs-lradc.c
@@ -1127,6 +1127,7 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
__set_bit(EV_ABS, input->evbit);
__set_bit(EV_KEY, input->evbit);
__set_bit(BTN_TOUCH, input->keybit);
+ __set_bit(INPUT_PROP_DIRECT, input->propbit);
input_set_abs_params(input, ABS_X, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
input_set_abs_params(input, ABS_Y, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
input_set_abs_params(input, ABS_PRESSURE, 0, LRADC_SINGLE_SAMPLE_MASK,
--
1.9.1

2016-04-16 19:26:51

by Jonathan Cameron

Subject: Re: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT

On 10/04/16 20:22, Ksenija Stanojevic wrote:
> Set INPUT_PROP_DIRECT to indicate that it is a touchscreen on the
> device to help userspace classify it.
>
> Signed-off-by: Ksenija Stanojevic <[email protected]>
Sounds correct to me. Dmitry?
> ---
> drivers/iio/adc/mxs-lradc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c
> index 07287af..e4c4c5c 100644
> --- a/drivers/iio/adc/mxs-lradc.c
> +++ b/drivers/iio/adc/mxs-lradc.c
> @@ -1127,6 +1127,7 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
> __set_bit(EV_ABS, input->evbit);
> __set_bit(EV_KEY, input->evbit);
> __set_bit(BTN_TOUCH, input->keybit);
> + __set_bit(INPUT_PROP_DIRECT, input->propbit);
> input_set_abs_params(input, ABS_X, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
> input_set_abs_params(input, ABS_Y, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
> input_set_abs_params(input, ABS_PRESSURE, 0, LRADC_SINGLE_SAMPLE_MASK,
>

2016-04-17 09:33:50

by Dmitry Torokhov

Subject: Re: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT

On Sat, Apr 16, 2016 at 08:26:48PM +0100, Jonathan Cameron wrote:
> On 10/04/16 20:22, Ksenija Stanojevic wrote:
> > Set INPUT_PROP_DIRECT to indicate that it is a touchscreen on the
> > device to help userspace classify it.
> >
> > Signed-off-by: Ksenija Stanojevic <[email protected]>
> Sounds correct to me. Dmitry?

Acked-by: Dmitry Torokhov <[email protected]>

> > ---
> > drivers/iio/adc/mxs-lradc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c
> > index 07287af..e4c4c5c 100644
> > --- a/drivers/iio/adc/mxs-lradc.c
> > +++ b/drivers/iio/adc/mxs-lradc.c
> > @@ -1127,6 +1127,7 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
> > __set_bit(EV_ABS, input->evbit);
> > __set_bit(EV_KEY, input->evbit);
> > __set_bit(BTN_TOUCH, input->keybit);
> > + __set_bit(INPUT_PROP_DIRECT, input->propbit);
> > input_set_abs_params(input, ABS_X, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
> > input_set_abs_params(input, ABS_Y, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
> > input_set_abs_params(input, ABS_PRESSURE, 0, LRADC_SINGLE_SAMPLE_MASK,
> >
>

--
Dmitry

2016-04-17 09:48:08

by Jonathan Cameron

Subject: Re: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT

On 17/04/16 10:33, Dmitry Torokhov wrote:
> On Sat, Apr 16, 2016 at 08:26:48PM +0100, Jonathan Cameron wrote:
>> On 10/04/16 20:22, Ksenija Stanojevic wrote:
>>> Set INPUT_PROP_DIRECT to indicate that it is a touchscreen on the
>>> device to help userspace classify it.
>>>
>>> Signed-off-by: Ksenija Stanojevic <[email protected]>
>> Sounds correct to me. Dmitry?
>
> Acked-by: Dmitry Torokhov <[email protected]>
Applied to the togreg branch of iio.git - initially pushed out
as testing for the autobuilders to mess with it.

Thanks,

Jonathan
>
>>> ---
>>> drivers/iio/adc/mxs-lradc.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c
>>> index 07287af..e4c4c5c 100644
>>> --- a/drivers/iio/adc/mxs-lradc.c
>>> +++ b/drivers/iio/adc/mxs-lradc.c
>>> @@ -1127,6 +1127,7 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
>>> __set_bit(EV_ABS, input->evbit);
>>> __set_bit(EV_KEY, input->evbit);
>>> __set_bit(BTN_TOUCH, input->keybit);
>>> + __set_bit(INPUT_PROP_DIRECT, input->propbit);
>>> input_set_abs_params(input, ABS_X, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
>>> input_set_abs_params(input, ABS_Y, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
>>> input_set_abs_params(input, ABS_PRESSURE, 0, LRADC_SINGLE_SAMPLE_MASK,
>>>
>>
>