2016-10-06 10:10:15

by Kiran Gunda

[permalink] [raw]
Subject: Re: [PATCH] spmi: regmap: enable userspace writes

On 2016-10-04 02:33, Stephen Boyd wrote:
> On 09/30, [email protected] wrote:
>> On 2016-09-29 23:30, Mark Brown wrote:
>> >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
>> >
>> >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS
>> >>+#define REGMAP_ALLOW_WRITE_DEBUGFS
>> >
>> >This is completely inappropriate for upstream, if you need to do
>> >debugging on your platform you can enable this locally but enabling
>> >random writes from userspace to any regmap device is really not a good
>> >idea for system stablity or robustness.
>>
>> Sure. I will remove this change and send the next version only to
>> update
>> the spmi device name.
>
> Why? The device name looks fine.
Ok. I will re-check and ignore the patch, if no changes required.