2017-06-16 12:02:57

by Arvind Yadav

Subject: [PATCH] ata: sata_rcar: make of_device_ids const.

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
3946 2296 0 6242 1862 drivers/ata/sata_rcar.o

File size after constify sata_rcar_match.
text data bss dec hex filename
5554 696 0 6250 186a drivers/ata/sata_rcar.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/ata/sata_rcar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
index 5d38245..35945e3 100644
--- a/drivers/ata/sata_rcar.c
+++ b/drivers/ata/sata_rcar.c
@@ -828,7 +828,7 @@ static void sata_rcar_init_controller(struct ata_host *host)
iowrite32(ATAPI_INT_ENABLE_SATAINT, base + ATAPI_INT_ENABLE_REG);
}

-static struct of_device_id sata_rcar_match[] = {
+static const struct of_device_id sata_rcar_match[] = {
{
/* Deprecated by "renesas,sata-r8a7779" */
.compatible = "renesas,rcar-sata",
--
1.9.1

2017-06-19 18:05:39

by Tejun Heo

Subject: Re: [PATCH] ata: sata_rcar: make of_device_ids const.

On Fri, Jun 16, 2017 at 05:32:21PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 3946 2296 0 6242 1862 drivers/ata/sata_rcar.o
>
> File size after constify sata_rcar_match.
> text data bss dec hex filename
> 5554 696 0 6250 186a drivers/ata/sata_rcar.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied to libata/for-4.13.

Thanks.

--
tejun