2017-06-24 07:57:43

by Yunlong Song

Subject: [PATCH] f2fs: avoid redundant f2fs_flush after remount

create_flush_cmd_control will create redundant issue_flush_thread after each
remount with flush_merge option.

Signed-off-by: Yunlong Song <[email protected]>
---
fs/f2fs/segment.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index a6d7738..57f9edc 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -555,6 +555,8 @@ int create_flush_cmd_control(struct f2fs_sb_info *sbi)

if (SM_I(sbi)->fcc_info) {
fcc = SM_I(sbi)->fcc_info;
+ if (fcc->f2fs_issue_flush)
+ return err;
goto init_thread;
}

--
1.8.5.2

2017-06-24 15:00:30

by Chao Yu

Subject: Re: [PATCH] f2fs: avoid redundant f2fs_flush after remount

On 2017/6/24 15:57, Yunlong Song wrote:
> create_flush_cmd_control will create redundant issue_flush_thread after each
> remount with flush_merge option.
>
> Signed-off-by: Yunlong Song <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

> ---
> fs/f2fs/segment.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index a6d7738..57f9edc 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -555,6 +555,8 @@ int create_flush_cmd_control(struct f2fs_sb_info *sbi)
>
> if (SM_I(sbi)->fcc_info) {
> fcc = SM_I(sbi)->fcc_info;
> + if (fcc->f2fs_issue_flush)
> + return err;
> goto init_thread;
> }
>
>