On Fri, May 05, 2017 at 07:45:18AM +0200, Karim Eshapa wrote:
> Use msleep() instead of stucking with
> long delay will be more efficient.
>
> Signed-off-by: Karim Eshapa <[email protected]>
> ---
> drivers/soc/fsl/qbman/qman.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Acked-by: Scott Wood <[email protected]>
(though the subject line should be "soc/qman: ...")
Leo, are you going to send this patch (and other qman patches) via
arm-soc?
-Scott
> -----Original Message-----
> From: Scott Wood [mailto:[email protected]]
> Sent: Saturday, June 24, 2017 9:47 PM
> To: Karim Eshapa <[email protected]>
> Cc: Roy Pledge <[email protected]>; [email protected];
> Claudiu Manoil <[email protected]>; [email protected];
> [email protected]; [email protected]; Leo Li
> <[email protected]>
> Subject: Re: [v3] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck
> hacking jiffies.
>
> On Fri, May 05, 2017 at 07:45:18AM +0200, Karim Eshapa wrote:
> > Use msleep() instead of stucking with
> > long delay will be more efficient.
> >
> > Signed-off-by: Karim Eshapa <[email protected]>
> > ---
> > drivers/soc/fsl/qbman/qman.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
>
> Acked-by: Scott Wood <[email protected]>
>
> (though the subject line should be "soc/qman: ...")
>
> Leo, are you going to send this patch (and other qman patches) via arm-soc?
Yes. I can take it through the pull request for soc/fsl via arm-soc. As mentioned in the feedback from David in another email, probably we should update the comment and commit message to mention how 10000 cycles becomes 1ms.
Regards,
Leo