2017-07-01 12:26:18

by Arvind Yadav

Subject: [PATCH] tee: tee_shm: Constify dma_buf_ops structures.

dma_buf_ops are not supposed to change at runtime. All functions
working with dma_buf_ops provided by <linux/dma-buf.h> work with
const dma_buf_ops. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
2026 112 0 2138 85a drivers/tee/tee_shm.o

File size After adding 'const':
text data bss dec hex filename
2138 0 0 2138 85a drivers/tee/tee_shm.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/tee/tee_shm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
index d356d7f0..4bc7956 100644
--- a/drivers/tee/tee_shm.c
+++ b/drivers/tee/tee_shm.c
@@ -80,7 +80,7 @@ static int tee_shm_op_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma)
size, vma->vm_page_prot);
}

-static struct dma_buf_ops tee_shm_dma_buf_ops = {
+static const struct dma_buf_ops tee_shm_dma_buf_ops = {
.map_dma_buf = tee_shm_op_map_dma_buf,
.unmap_dma_buf = tee_shm_op_unmap_dma_buf,
.release = tee_shm_op_release,
--
2.7.4

2017-07-05 06:59:20

by Jens Wiklander

Subject: Re: [PATCH] tee: tee_shm: Constify dma_buf_ops structures.

On Sat, Jul 01, 2017 at 05:56:06PM +0530, Arvind Yadav wrote:
> dma_buf_ops are not supposed to change at runtime. All functions
> working with dma_buf_ops provided by <linux/dma-buf.h> work with
> const dma_buf_ops. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2026 112 0 2138 85a drivers/tee/tee_shm.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2138 0 0 2138 85a drivers/tee/tee_shm.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Looks good to me, queueing this.

Thanks,
Jens