2017-07-21 16:22:03

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency

Without this, I get a build error:

drivers/staging/media/imx/imx-media-vdic.c: In function '__vdic_get_fmt':
drivers/staging/media/imx/imx-media-vdic.c:554:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? [-Werror=implicit-function-declaration]

Fixes: e130291212df ("[media] media: Add i.MX media core driver")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/staging/media/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
index 7eff50bcea39..719508fcb0e9 100644
--- a/drivers/staging/media/imx/Kconfig
+++ b/drivers/staging/media/imx/Kconfig
@@ -1,6 +1,7 @@
config VIDEO_IMX_MEDIA
tristate "i.MX5/6 V4L2 media core driver"
depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
+ depends on VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
---help---
Say yes here to enable support for video4linux media controller
--
2.9.0


2017-07-22 18:52:42

by Steve Longerbeam

[permalink] [raw]
Subject: Re: [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency

Acked-by: Steve Longerbeam <[email protected]>

On 07/21/2017 09:21 AM, Arnd Bergmann wrote:
> Without this, I get a build error:
>
> drivers/staging/media/imx/imx-media-vdic.c: In function '__vdic_get_fmt':
> drivers/staging/media/imx/imx-media-vdic.c:554:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? [-Werror=implicit-function-declaration]
>
> Fixes: e130291212df ("[media] media: Add i.MX media core driver")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/staging/media/imx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index 7eff50bcea39..719508fcb0e9 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -1,6 +1,7 @@
> config VIDEO_IMX_MEDIA
> tristate "i.MX5/6 V4L2 media core driver"
> depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
> + depends on VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> ---help---
> Say yes here to enable support for video4linux media controller
>