2017-08-25 16:11:44

by Himanshu Jha

Subject: [PATCH] RDMA/bnxt_re: remove unnecessary call to memset

call to memset to assign 0 value immediately after allocating
memory with kzalloc is unnecesaary as kzalloc allocates the memory
filled with 0 value.

Signed-off-by: Himanshu Jha <[email protected]>
---
drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index f0e01b3..fa6fbac 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -969,7 +969,6 @@ static struct bnxt_re_ah *bnxt_re_create_shadow_qp_ah
if (!ah)
return NULL;

- memset(ah, 0, sizeof(*ah));
ah->rdev = rdev;
ah->qplib_ah.pd = &pd->qplib_pd;

@@ -1016,7 +1015,6 @@ static struct bnxt_re_qp *bnxt_re_create_shadow_qp
if (!qp)
return NULL;

- memset(qp, 0, sizeof(*qp));
qp->rdev = rdev;

/* Initialize the shadow QP structure from the QP1 values */
--
2.7.4

2017-08-27 08:17:13

by Yuval Shaia

Subject: Re: [PATCH] RDMA/bnxt_re: remove unnecessary call to memset

On Fri, Aug 25, 2017 at 09:41:02PM +0530, Himanshu Jha wrote:
> call to memset to assign 0 value immediately after allocating
> memory with kzalloc is unnecesaary as kzalloc allocates the memory
> filled with 0 value.
>
> Signed-off-by: Himanshu Jha <[email protected]>
> ---
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> index f0e01b3..fa6fbac 100644
> --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> @@ -969,7 +969,6 @@ static struct bnxt_re_ah *bnxt_re_create_shadow_qp_ah
> if (!ah)
> return NULL;
>
> - memset(ah, 0, sizeof(*ah));
> ah->rdev = rdev;
> ah->qplib_ah.pd = &pd->qplib_pd;
>
> @@ -1016,7 +1015,6 @@ static struct bnxt_re_qp *bnxt_re_create_shadow_qp
> if (!qp)
> return NULL;
>
> - memset(qp, 0, sizeof(*qp));
> qp->rdev = rdev;
>
> /* Initialize the shadow QP structure from the QP1 values */
> --
> 2.7.4

FWIW

Reviewed-by: Yuval Shaia <[email protected]>

>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2017-08-28 23:17:15

by Doug Ledford

Subject: Re: [PATCH] RDMA/bnxt_re: remove unnecessary call to memset

On Fri, 2017-08-25 at 21:41 +0530, Himanshu Jha wrote:
> call to memset to assign 0 value immediately after allocating
> memory with kzalloc is unnecesaary as kzalloc allocates the memory
> filled with 0 value.
>
> Signed-off-by: Himanshu Jha <[email protected]>

Thanks, applied.

--
Doug Ledford <[email protected]>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD