2017-09-27 00:33:13

by Yury Norov

Subject: [PATCH] IPC: fix put_compat_shm_info()

There's a typo in put_compat_shm_info() - the first argument
of copy_to_user() is 'up' instead of 'uip'. And 'up' is
occasionly a suitable variable name so the compiler doesn't
complain.

Signed-off-by: Yury Norov <[email protected]>
---
ipc/shm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipc/shm.c b/ipc/shm.c
index 1e2b1692ba2c..badac463e2c8 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -1154,7 +1154,7 @@ static int put_compat_shm_info(struct shm_info *ip,
info.shm_swp = ip->shm_swp;
info.swap_attempts = ip->swap_attempts;
info.swap_successes = ip->swap_successes;
- return copy_to_user(up, &info, sizeof(info));
+ return copy_to_user(uip, &info, sizeof(info));
}

static int copy_compat_shmid_to_user(void __user *buf, struct shmid64_ds *in,
--
2.11.0

2017-09-27 00:49:37

by Yury Norov

Subject: Re: [PATCH] IPC: fix put_compat_shm_info()

On Wed, Sep 27, 2017 at 03:32:54AM +0300, Yury Norov wrote:
> There's a typo in put_compat_shm_info() - the first argument
> of copy_to_user() is 'up' instead of 'uip'. And 'up' is
> occasionly a suitable variable name so the compiler doesn't
> complain.
>
> Signed-off-by: Yury Norov <[email protected]>

Ah, I just pulled latest sources and found it already fixed.
Please forget.

> ---
> ipc/shm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ipc/shm.c b/ipc/shm.c
> index 1e2b1692ba2c..badac463e2c8 100644
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -1154,7 +1154,7 @@ static int put_compat_shm_info(struct shm_info *ip,
> info.shm_swp = ip->shm_swp;
> info.swap_attempts = ip->swap_attempts;
> info.swap_successes = ip->swap_successes;
> - return copy_to_user(up, &info, sizeof(info));
> + return copy_to_user(uip, &info, sizeof(info));
> }
>
> static int copy_compat_shmid_to_user(void __user *buf, struct shmid64_ds *in,
> --
> 2.11.0