2018-01-17 03:41:02

by Matthew Wilcox

Subject: [PATCH] Documentation: Fix misconversion of #if

From: Matthew Wilcox <[email protected]>

At some stage of the conversion pipeline, something thought that the
DocBook entity &num; should be rendered as NUM instead of #.

Signed-off-by: Matthew Wilcox <[email protected]>
---
Documentation/kernel-hacking/hacking.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/kernel-hacking/hacking.rst b/Documentation/kernel-hacking/hacking.rst
index daf3883b2694..5c4d30e81b7f 100644
--- a/Documentation/kernel-hacking/hacking.rst
+++ b/Documentation/kernel-hacking/hacking.rst
@@ -690,8 +690,8 @@ not provide the necessary runtime environment and the include files are
not tested for it. It is still possible, but not recommended. If you
really want to do this, forget about exceptions at least.

-NUMif
------
+#if
+---

It is generally considered cleaner to use macros in header files (or at
the top of .c files) to abstract away functions rather than using \`#if'
--
2.15.1

2018-01-17 11:04:58

by Mauro Carvalho Chehab

Subject: Re: [PATCH] Documentation: Fix misconversion of #if

Em Tue, 16 Jan 2018 19:40:55 -0800
Matthew Wilcox <[email protected]> escreveu:

> From: Matthew Wilcox <[email protected]>
>
> At some stage of the conversion pipeline, something thought that the
> DocBook entity &num; should be rendered as NUM instead of #.
>
> Signed-off-by: Matthew Wilcox <[email protected]>
Reviewed-by: Mauro Carvalho Chehab <[email protected]>
> ---
> Documentation/kernel-hacking/hacking.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/kernel-hacking/hacking.rst b/Documentation/kernel-hacking/hacking.rst
> index daf3883b2694..5c4d30e81b7f 100644
> --- a/Documentation/kernel-hacking/hacking.rst
> +++ b/Documentation/kernel-hacking/hacking.rst
> @@ -690,8 +690,8 @@ not provide the necessary runtime environment and the include files are
> not tested for it. It is still possible, but not recommended. If you
> really want to do this, forget about exceptions at least.
>
> -NUMif
> ------
> +#if
> +---
>
> It is generally considered cleaner to use macros in header files (or at
> the top of .c files) to abstract away functions rather than using \`#if'



Thanks,
Mauro

2018-01-17 23:47:04

by Jonathan Corbet

Subject: Re: [PATCH] Documentation: Fix misconversion of #if

On Tue, 16 Jan 2018 19:40:55 -0800
Matthew Wilcox <[email protected]> wrote:

> At some stage of the conversion pipeline, something thought that the
> DocBook entity &num; should be rendered as NUM instead of #.

Haven't you heard? It's a new, improved form of C trigraph... :)

Applied, thanks.

jon