2018-01-20 21:29:22

by SF Markus Elfring

Subject: [PATCH 0/2] Input-sur40: Adjustments for sur40_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 20 Jan 2018 22:20:10 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/input/touchscreen/sur40.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

--
2.15.1

2018-01-20 21:31:49

by SF Markus Elfring

Subject: [PATCH 1/2] Input: sur40: Delete an error message for a failed memory allocation in sur40_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 20 Jan 2018 22:11:24 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/touchscreen/sur40.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
index f16f8358c70a..c7a0a92b2044 100644
--- a/drivers/input/touchscreen/sur40.c
+++ b/drivers/input/touchscreen/sur40.c
@@ -591,7 +591,6 @@ static int sur40_probe(struct usb_interface *interface,
sur40->bulk_in_epaddr = endpoint->bEndpointAddress;
sur40->bulk_in_buffer = kmalloc(sur40->bulk_in_size, GFP_KERNEL);
if (!sur40->bulk_in_buffer) {
- dev_err(&interface->dev, "Unable to allocate input buffer.");
error = -ENOMEM;
goto err_free_polldev;
}
--
2.15.1

2018-01-20 21:32:11

by SF Markus Elfring

Subject: [PATCH 2/2] Input: sur40: Improve a size determination in sur40_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 20 Jan 2018 22:16:14 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/touchscreen/sur40.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
index c7a0a92b2044..946e1a0328b4 100644
--- a/drivers/input/touchscreen/sur40.c
+++ b/drivers/input/touchscreen/sur40.c
@@ -550,7 +550,7 @@ static int sur40_probe(struct usb_interface *interface,
return -ENODEV;

/* Allocate memory for our device state and initialize it. */
- sur40 = kzalloc(sizeof(struct sur40_state), GFP_KERNEL);
+ sur40 = kzalloc(sizeof(*sur40), GFP_KERNEL);
if (!sur40)
return -ENOMEM;

--
2.15.1

2018-01-22 07:01:12

by Martin Kepplinger

Subject: Re: [PATCH 1/2] Input: sur40: Delete an error message for a failed memory allocation in sur40_probe()

On 2018-01-20 22:28, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Sat, 20 Jan 2018 22:11:24 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Acked-by: Martin Kepplinger <[email protected]>

> ---
> drivers/input/touchscreen/sur40.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index f16f8358c70a..c7a0a92b2044 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -591,7 +591,6 @@ static int sur40_probe(struct usb_interface *interface,
> sur40->bulk_in_epaddr = endpoint->bEndpointAddress;
> sur40->bulk_in_buffer = kmalloc(sur40->bulk_in_size, GFP_KERNEL);
> if (!sur40->bulk_in_buffer) {
> - dev_err(&interface->dev, "Unable to allocate input buffer.");
> error = -ENOMEM;
> goto err_free_polldev;
> }
>

2018-01-22 07:03:36

by Martin Kepplinger

Subject: Re: [PATCH 2/2] Input: sur40: Improve a size determination in sur40_probe()

On 2018-01-20 22:30, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Sat, 20 Jan 2018 22:16:14 +0100
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Acked-by: Martin Kepplinger <[email protected]>

> ---
> drivers/input/touchscreen/sur40.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index c7a0a92b2044..946e1a0328b4 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -550,7 +550,7 @@ static int sur40_probe(struct usb_interface *interface,
> return -ENODEV;
>
> /* Allocate memory for our device state and initialize it. */
> - sur40 = kzalloc(sizeof(struct sur40_state), GFP_KERNEL);
> + sur40 = kzalloc(sizeof(*sur40), GFP_KERNEL);
> if (!sur40)
> return -ENOMEM;
>
>