2018-06-06 19:27:57

by Corentin LABBE

Subject: [PATCH] mmc: dw_mmc should depend on COMMON_CLK

This patch fix the following build failure on m68k:
ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 0581c199c996..77d6ba090436 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -666,7 +666,7 @@ config MMC_CAVIUM_THUNDERX

config MMC_DW
tristate "Synopsys DesignWare Memory Card Interface"
- depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
+ depends on COMMON_CLK && (ARC || ARM || ARM64 || MIPS || COMPILE_TEST)
help
This selects support for the Synopsys DesignWare Mobile Storage IP
block, this provides host support for SD and MMC interfaces, in both
--
2.16.4

2018-06-12 17:08:39

by Andy Shevchenko

Subject: Re: [PATCH] mmc: dw_mmc should depend on COMMON_CLK

+Cc: Geert

On Wed, Jun 6, 2018 at 9:43 PM, Corentin Labbe <[email protected]> wrote:
> This patch fix the following build failure on m68k:
> ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 0581c199c996..77d6ba090436 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -666,7 +666,7 @@ config MMC_CAVIUM_THUNDERX
>
> config MMC_DW
> tristate "Synopsys DesignWare Memory Card Interface"
> - depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
> + depends on COMMON_CLK && (ARC || ARM || ARM64 || MIPS || COMPILE_TEST)
> help
> This selects support for the Synopsys DesignWare Mobile Storage IP
> block, this provides host support for SD and MMC interfaces, in both
> --
> 2.16.4
>



--
With Best Regards,
Andy Shevchenko

2018-07-02 13:18:37

by Ulf Hansson

Subject: Re: [PATCH] mmc: dw_mmc should depend on COMMON_CLK

On 6 June 2018 at 20:43, Corentin Labbe <[email protected]> wrote:
> This patch fix the following build failure on m68k:
> ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!
>
> Signed-off-by: Corentin Labbe <[email protected]>

Thanks, applied for next!

Kind regards
Uffe

> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 0581c199c996..77d6ba090436 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -666,7 +666,7 @@ config MMC_CAVIUM_THUNDERX
>
> config MMC_DW
> tristate "Synopsys DesignWare Memory Card Interface"
> - depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
> + depends on COMMON_CLK && (ARC || ARM || ARM64 || MIPS || COMPILE_TEST)
> help
> This selects support for the Synopsys DesignWare Mobile Storage IP
> block, this provides host support for SD and MMC interfaces, in both
> --
> 2.16.4
>

2018-07-02 13:34:35

by Geert Uytterhoeven

Subject: Re: [PATCH] mmc: dw_mmc should depend on COMMON_CLK

Hi Ulf,

On Mon, Jul 2, 2018 at 3:18 PM Ulf Hansson <[email protected]> wrote:
> On 6 June 2018 at 20:43, Corentin Labbe <[email protected]> wrote:
> > This patch fix the following build failure on m68k:
> > ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!
> >
> > Signed-off-by: Corentin Labbe <[email protected]>
>
> Thanks, applied for next!

Please drop this patch, I posted proper fixes for this general issue in series
"[PATCH 0/3] Legacy clock drivers: Normalize clk API"
(https://lkml.org/lkml/2018/6/11/122).

All fixes above are already in next-20180702.
Thanks!

> > ---
> > drivers/mmc/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 0581c199c996..77d6ba090436 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -666,7 +666,7 @@ config MMC_CAVIUM_THUNDERX
> >
> > config MMC_DW
> > tristate "Synopsys DesignWare Memory Card Interface"
> > - depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
> > + depends on COMMON_CLK && (ARC || ARM || ARM64 || MIPS || COMPILE_TEST)
> > help
> > This selects support for the Synopsys DesignWare Mobile Storage IP
> > block, this provides host support for SD and MMC interfaces, in both

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2018-07-02 14:40:27

by Ulf Hansson

Subject: Re: [PATCH] mmc: dw_mmc should depend on COMMON_CLK

On 2 July 2018 at 15:32, Geert Uytterhoeven <[email protected]> wrote:
> Hi Ulf,
>
> On Mon, Jul 2, 2018 at 3:18 PM Ulf Hansson <[email protected]> wrote:
>> On 6 June 2018 at 20:43, Corentin Labbe <[email protected]> wrote:
>> > This patch fix the following build failure on m68k:
>> > ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!
>> >
>> > Signed-off-by: Corentin Labbe <[email protected]>
>>
>> Thanks, applied for next!
>
> Please drop this patch, I posted proper fixes for this general issue in series
> "[PATCH 0/3] Legacy clock drivers: Normalize clk API"
> (https://lkml.org/lkml/2018/6/11/122).
>
> All fixes above are already in next-20180702.
> Thanks!

Thanks for letting me know, patch dropped!

I had the feeling there was a better way. :-)

[...]

Kind regards
Uffe