2018-07-08 09:59:07

by Bernd Edlinger

Subject: [PATCH] Add a missing break in parse_station_flags

I was looking at usually suppressed gcc warnings,
[-Wimplicit-fallthrough=] in this case:

The code definitely looks like a break is missing here.
However I am not able to test the NL80211_IFTYPE_MESH_POINT,
nor do I actually know what might be :)
So please use this patch with caution and only if you are
able to do some testing.

Signed-off-by: Bernd Edlinger <[email protected]>
---
net/wireless/nl80211.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 4eece06..6537b5d 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -4409,6 +4409,7 @@ static int parse_station_flags(struct genl_info *info,
params->sta_flags_mask = BIT(NL80211_STA_FLAG_AUTHENTICATED) |
BIT(NL80211_STA_FLAG_MFP) |
BIT(NL80211_STA_FLAG_AUTHORIZED);
+ break;
default:
return -EINVAL;
}
--
1.9.1

2018-07-23 09:32:26

by Kalle Valo

Subject: Re: [PATCH] Add a missing break in parse_station_flags

Bernd Edlinger <[email protected]> writes:

> I was looking at usually suppressed gcc warnings,
> [-Wimplicit-fallthrough=] in this case:
>
> The code definitely looks like a break is missing here.
> However I am not able to test the NL80211_IFTYPE_MESH_POINT,
> nor do I actually know what might be :)
> So please use this patch with caution and only if you are
> able to do some testing.
>
> Signed-off-by: Bernd Edlinger <[email protected]>
> ---
> net/wireless/nl80211.c | 1 +
> 1 file changed, 1 insertion(+)

You should use prefix "nl80211: " in the title.

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject

--
Kalle Valo