2018-07-11 08:25:27

by Colin King

Subject: [PATCH] rapidio: remove redundant pointer md

From: Colin Ian King <[email protected]>

Pointer md is being assigned but is never used hence it is redundant
and can be removed.

Cleans up clang warning:
warning: variable 'md' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/rapidio/devices/rio_mport_cdev.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
index a8cb8d2f2abb..cbe467ff1aba 100644
--- a/drivers/rapidio/devices/rio_mport_cdev.c
+++ b/drivers/rapidio/devices/rio_mport_cdev.c
@@ -1006,7 +1006,6 @@ static int rio_mport_transfer_ioctl(struct file *filp, void __user *arg)
static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
{
struct mport_cdev_priv *priv;
- struct mport_dev *md;
struct rio_async_tx_wait w_param;
struct mport_dma_req *req;
dma_cookie_t cookie;
@@ -1016,7 +1015,6 @@ static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
int ret;

priv = (struct mport_cdev_priv *)filp->private_data;
- md = priv->md;

if (unlikely(copy_from_user(&w_param, arg, sizeof(w_param))))
return -EFAULT;
--
2.17.1

2018-07-20 00:26:06

by alex.b

Subject: Re: [PATCH] rapidio: remove redundant pointer md

Acked-by: Alexandre Bounine <[email protected]>


On 2018-07-11 04:23 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Pointer md is being assigned but is never used hence it is redundant
> and can be removed.
>
> Cleans up clang warning:
> warning: variable 'md' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/rapidio/devices/rio_mport_cdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
> index a8cb8d2f2abb..cbe467ff1aba 100644
> --- a/drivers/rapidio/devices/rio_mport_cdev.c
> +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> @@ -1006,7 +1006,6 @@ static int rio_mport_transfer_ioctl(struct file *filp, void __user *arg)
> static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
> {
> struct mport_cdev_priv *priv;
> - struct mport_dev *md;
> struct rio_async_tx_wait w_param;
> struct mport_dma_req *req;
> dma_cookie_t cookie;
> @@ -1016,7 +1015,6 @@ static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
> int ret;
>
> priv = (struct mport_cdev_priv *)filp->private_data;
> - md = priv->md;
>
> if (unlikely(copy_from_user(&w_param, arg, sizeof(w_param))))
> return -EFAULT;
>