2003-11-15 23:26:14

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] disallow modular BINFMT_ELF

modular BINFMT_ELF gives unresolved symbols in 2.4 .

modular BINFMT_ELF gives the following unresolved symbols in 2.6:

<-- snip -->

WARNING: /lib/modules/2.6.0-test9-mm3/kernel/fs/binfmt_elf.ko needs
unknown symbol __kernel_vsyscall
WARNING: /lib/modules/2.6.0-test9-mm3/kernel/fs/binfmt_elf.ko needs
unknown symbol empty_zero_page
WARNING: /lib/modules/2.6.0-test9-mm3/kernel/fs/binfmt_elf.ko needs
unknown symbol dump_task_fpu
WARNING: /lib/modules/2.6.0-test9-mm3/kernel/fs/binfmt_elf.ko needs
unknown symbol dump_task_extended_fpu
WARNING: /lib/modules/2.6.0-test9-mm3/kernel/fs/binfmt_elf.ko needs
unknown symbol dump_task_regs

<-- snip -->


Since modular BINFMT_ELF is pretty pathological I'd suggest the
following patch:

--- linux-2.6.0-test9-mm3/fs/Kconfig.binfmt.old 2003-11-15 23:43:24.000000000 +0100
+++ linux-2.6.0-test9-mm3/fs/Kconfig.binfmt 2003-11-15 23:43:49.000000000 +0100
@@ -1,5 +1,5 @@
config BINFMT_ELF
- tristate "Kernel support for ELF binaries"
+ bool "Kernel support for ELF binaries"
depends on MMU
default y
---help---



cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


2003-11-15 23:48:28

by Jeff Garzik

[permalink] [raw]
Subject: Re: [2.6 patch] disallow modular BINFMT_ELF

Adrian Bunk wrote:
> modular BINFMT_ELF gives unresolved symbols in 2.4 .
>
> modular BINFMT_ELF gives the following unresolved symbols in 2.6:


Interesting. this causes me to wonder if we should bother making
BINFMT_ELF an option at all...

Jeff



2003-11-15 23:54:03

by Martin Hicks

[permalink] [raw]
Subject: Re: [2.6 patch] disallow modular BINFMT_ELF

On Sat, 2003-11-15 at 18:48, Jeff Garzik wrote:
> Adrian Bunk wrote:
> > modular BINFMT_ELF gives unresolved symbols in 2.4 .
> >
> > modular BINFMT_ELF gives the following unresolved symbols in 2.6:
>
>
> Interesting. this causes me to wonder if we should bother making
> BINFMT_ELF an option at all...

I strikes me as something that everyone is going to say yes to. If
someone really doesn't want ELF then they are probably smart enough to
change the Config script.

mh

--
Martin Hicks || [email protected] || PGP/GnuPG: 0x4C7F2BEE


Attachments:
signature.asc (189.00 B)
This is a digitally signed message part

2003-11-17 01:12:18

by Eric W. Biederman

[permalink] [raw]
Subject: Re: [2.6 patch] disallow modular BINFMT_ELF

Jeff Garzik <[email protected]> writes:

> Adrian Bunk wrote:
> > modular BINFMT_ELF gives unresolved symbols in 2.4 .
> > modular BINFMT_ELF gives the following unresolved symbols in 2.6:
>
>
> Interesting. this causes me to wonder if we should bother making BINFMT_ELF an
>
> option at all...

We have platforms uClinux for which ELF is not the preferred format so we
should at least be able to compile it out.

Eric

2003-11-17 09:26:27

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [2.6 patch] disallow modular BINFMT_ELF

On Sat, Nov 15, 2003 at 06:48:05PM -0500, Jeff Garzik wrote:
> Adrian Bunk wrote:
> > modular BINFMT_ELF gives unresolved symbols in 2.4 .
> >
> > modular BINFMT_ELF gives the following unresolved symbols in 2.6:
>
>
> Interesting. this causes me to wonder if we should bother making
> BINFMT_ELF an option at all...

And in addition to my previous post there's probably peopel who want only
32bit elf support on 64bit arches like paris64 and sparc64.

2003-11-17 09:25:28

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [2.6 patch] disallow modular BINFMT_ELF

On Sat, Nov 15, 2003 at 06:48:05PM -0500, Jeff Garzik wrote:
> Adrian Bunk wrote:
> > modular BINFMT_ELF gives unresolved symbols in 2.4 .
> >
> > modular BINFMT_ELF gives the following unresolved symbols in 2.6:
>
>
> Interesting. this causes me to wonder if we should bother making
> BINFMT_ELF an option at all...

Many nommu targets don't support ELF binaries at all.

2003-11-17 13:09:24

by Jakub Jelinek

[permalink] [raw]
Subject: Re: [2.6 patch] disallow modular BINFMT_ELF

On Sun, Nov 16, 2003 at 06:09:11PM -0700, Eric W. Biederman wrote:
> Jeff Garzik <[email protected]> writes:
>
> > Adrian Bunk wrote:
> > > modular BINFMT_ELF gives unresolved symbols in 2.4 .
> > > modular BINFMT_ELF gives the following unresolved symbols in 2.6:
> >
> >
> > Interesting. this causes me to wonder if we should bother making BINFMT_ELF an
> >
> > option at all...
>
> We have platforms uClinux for which ELF is not the preferred format so we
> should at least be able to compile it out.

Similarly on bi-arch supporting platforms, CONFIG_BINFMT_ELF controls
64-bit ELF support which one might want to disable and only use
CONFIG_BINFMT_ELF32 (or other config option which controls 32-bit ELF
support).

Jakub