2018-11-01 15:01:22

by Peng Hao

[permalink] [raw]
Subject: [PATCH v2] x86/kvmclock : convert to SPDX identifiers


From: Peng Hao <[email protected]>

This patch updates license to use SPDX-License-Identifier
instead of verbose license text

Signed-off-by: Peng Hao <[email protected]>
---
arch/x86/kernel/kvmclock.c | 15 +--------------
1 files changed, 1 insertions(+), 14 deletions(-)

diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
index 1e67646..0ebd715 100644
--- a/arch/x86/kernel/kvmclock.c
+++ b/arch/x86/kernel/kvmclock.c
@@ -1,19 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0+
/* KVM paravirtual clock driver. A clocksource implementation
Copyright (C) 2008 Glauber de Oliveira Costa, Red Hat Inc.
-
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation; either version 2 of the License, or
- (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
-
- You should have received a copy of the GNU General Public License
- along with this program; if not, write to the Free Software
- Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/

#include <linux/clocksource.h>
--
1.8.3.1




2018-11-01 16:06:31

by Thomas Gleixner

[permalink] [raw]
Subject: Re: [PATCH v2] x86/kvmclock : convert to SPDX identifiers

Peng,

On Thu, 1 Nov 2018, Peng Hao wrote:

> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text

Again:

git grep 'This patch' Documentation/process/

This leads you to:

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour."

Documentation is there for a reason.

IOW, writing 'This patch does ....' is not the proper way for writing a
changelog. It's entirely clear that this is a patch. No need to mention
it. Imperative mood means something like this:

Replace the verbose license text with the matching SPDX license identifier.

Thanks,

tglx