2018-11-20 14:14:35

by Frank Lee

Subject: [PATCH] RISC-V: add of_node_put()

use of_node_put() to release the refcount.

Signed-off-by: Yangtao Li <[email protected]>
---
arch/riscv/kernel/time.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/riscv/kernel/time.c b/arch/riscv/kernel/time.c
index 1911c8f6b8a6..40470e669a35 100644
--- a/arch/riscv/kernel/time.c
+++ b/arch/riscv/kernel/time.c
@@ -26,6 +26,7 @@ void __init time_init(void)
cpu = of_find_node_by_path("/cpus");
if (!cpu || of_property_read_u32(cpu, "timebase-frequency", &prop))
panic(KERN_WARNING "RISC-V system with no 'timebase-frequency' in DTS\n");
+ of_node_put(cpu);
riscv_timebase = prop;

lpj_fine = riscv_timebase / HZ;
--
2.17.0

2018-11-20 17:31:04

by Palmer Dabbelt

Subject: Re: [PATCH] RISC-V: add of_node_put()

On Tue, 20 Nov 2018 06:11:02 PST (-0800), [email protected] wrote:
> use of_node_put() to release the refcount.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> arch/riscv/kernel/time.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/kernel/time.c b/arch/riscv/kernel/time.c
> index 1911c8f6b8a6..40470e669a35 100644
> --- a/arch/riscv/kernel/time.c
> +++ b/arch/riscv/kernel/time.c
> @@ -26,6 +26,7 @@ void __init time_init(void)
> cpu = of_find_node_by_path("/cpus");
> if (!cpu || of_property_read_u32(cpu, "timebase-frequency", &prop))
> panic(KERN_WARNING "RISC-V system with no 'timebase-frequency' in DTS\n");
> + of_node_put(cpu);
> riscv_timebase = prop;
>
> lpj_fine = riscv_timebase / HZ;

Thanks. I'm going to target this for next week's PR.