2019-01-23 08:52:47

by Yue Haibing

Subject: [PATCH -next] gpio: davinci: drop pointless static qualifier

There is no need to have the 'gpio_unbanked' variable static since
new value always be assigned before use it.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpio/gpio-davinci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index bdb29e5..f250454 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -465,7 +465,7 @@ static const struct irq_domain_ops davinci_gpio_irq_ops = {

static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
{
- static struct irq_chip_type gpio_unbanked;
+ struct irq_chip_type gpio_unbanked;

gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));

@@ -474,7 +474,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)

static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)
{
- static struct irq_chip gpio_unbanked;
+ struct irq_chip gpio_unbanked;

gpio_unbanked = *irq_get_chip(irq);
return &gpio_unbanked;
--
2.7.0

2019-01-23 10:34:11

by Keerthy

Subject: Re: [PATCH -next] gpio: davinci: drop pointless static qualifier

On 23/01/19 2:19 PM, YueHaibing wrote:
> There is no need to have the 'gpio_unbanked' variable static since
> new value always be assigned before use it.

Acked-by: Keerthy <[email protected]>

>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/gpio/gpio-davinci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index bdb29e5..f250454 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -465,7 +465,7 @@ static const struct irq_domain_ops davinci_gpio_irq_ops = {
>
> static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
> {
> - static struct irq_chip_type gpio_unbanked;
> + struct irq_chip_type gpio_unbanked;
>
> gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
>
> @@ -474,7 +474,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
>
> static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)
> {
> - static struct irq_chip gpio_unbanked;
> + struct irq_chip gpio_unbanked;
>
> gpio_unbanked = *irq_get_chip(irq);
> return &gpio_unbanked;
>

2019-01-23 16:14:37

by Bartosz Golaszewski

Subject: Re: [PATCH -next] gpio: davinci: drop pointless static qualifier

śr., 23 sty 2019 o 11:32 Keerthy <[email protected]> napisał(a):
>
> On 23/01/19 2:19 PM, YueHaibing wrote:
> > There is no need to have the 'gpio_unbanked' variable static since
> > new value always be assigned before use it.
>
> Acked-by: Keerthy <[email protected]>
>
> >
> > Signed-off-by: YueHaibing <[email protected]>
> > ---
> > drivers/gpio/gpio-davinci.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> > index bdb29e5..f250454 100644
> > --- a/drivers/gpio/gpio-davinci.c
> > +++ b/drivers/gpio/gpio-davinci.c
> > @@ -465,7 +465,7 @@ static const struct irq_domain_ops davinci_gpio_irq_ops = {
> >
> > static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
> > {
> > - static struct irq_chip_type gpio_unbanked;
> > + struct irq_chip_type gpio_unbanked;
> >
> > gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
> >
> > @@ -474,7 +474,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
> >
> > static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)
> > {
> > - static struct irq_chip gpio_unbanked;
> > + struct irq_chip gpio_unbanked;
> >
> > gpio_unbanked = *irq_get_chip(irq);
> > return &gpio_unbanked;
> >
>

Good catch! While it would probably never result in a race condition
as it is always called from probe(), it's still wrong so patch
applied.

Thanks,
Bart