2019-02-01 03:38:06

by Yue Haibing

Subject: [PATCH -next] remoteproc: make rproc_check_carveout_da static

Fixes the following sparse warnings:

drivers/remoteproc/remoteproc_core.c:279:5: warning:
symbol 'rproc_check_carveout_da' was not declared. Should it be static?

Signed-off-by: YueHaibing <[email protected]>
---
drivers/remoteproc/remoteproc_core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 54ec38f..5d4954d 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -276,8 +276,9 @@ rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...)
*
* Return: 0 if carveout match request else -ENOMEM
*/
-int rproc_check_carveout_da(struct rproc *rproc, struct rproc_mem_entry *mem,
- u32 da, u32 len)
+static int rproc_check_carveout_da(struct rproc *rproc,
+ struct rproc_mem_entry *mem,
+ u32 da, u32 len)
{
struct device *dev = &rproc->dev;
int delta = 0;
--
2.7.0

2019-02-01 15:58:57

by Loic Pallardy

Subject: RE: [PATCH -next] remoteproc: make rproc_check_carveout_da static

Hi Yue,

> -----Original Message-----
> From: [email protected] <linux-remoteproc-
> [email protected]> On Behalf Of YueHaibing
> Sent: vendredi 1 f?vrier 2019 04:13
> To: [email protected]; [email protected]
> Cc: [email protected]; [email protected];
> YueHaibing <[email protected]>
> Subject: [PATCH -next] remoteproc: make rproc_check_carveout_da static
>
> Fixes the following sparse warnings:
>
> drivers/remoteproc/remoteproc_core.c:279:5: warning:
> symbol 'rproc_check_carveout_da' was not declared. Should it be static?
Correction already sent on ML few weeks ago. See [1]

Regards,
Loic

[1] https://patchwork.kernel.org/patch/10755763/

>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/remoteproc/remoteproc_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> index 54ec38f..5d4954d 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -276,8 +276,9 @@ rproc_find_carveout_by_name(struct rproc *rproc,
> const char *name, ...)
> *
> * Return: 0 if carveout match request else -ENOMEM
> */
> -int rproc_check_carveout_da(struct rproc *rproc, struct rproc_mem_entry
> *mem,
> - u32 da, u32 len)
> +static int rproc_check_carveout_da(struct rproc *rproc,
> + struct rproc_mem_entry *mem,
> + u32 da, u32 len)
> {
> struct device *dev = &rproc->dev;
> int delta = 0;
> --
> 2.7.0
>