2019-02-22 09:11:06

by Axel Lin

Subject: [PATCH] regulator: max77650: Fix set_current_limit implementation

Current code always return error, fix it.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/max77650-regulator.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/max77650-regulator.c b/drivers/regulator/max77650-regulator.c
index 411912d5278b..a1af414db751 100644
--- a/drivers/regulator/max77650-regulator.c
+++ b/drivers/regulator/max77650-regulator.c
@@ -243,7 +243,7 @@ static int max77650_regulator_set_current_limit(struct regulator_dev *rdev,
{
struct max77650_regulator_desc *rdesc;
struct regmap *map;
- int rv, i, limit;
+ int i, limit;

rdesc = rdev_get_drvdata(rdev);
map = rdev_get_regmap(rdev);
@@ -252,11 +252,9 @@ static int max77650_regulator_set_current_limit(struct regulator_dev *rdev,
limit = max77650_current_limit_table[i];

if (limit >= min_uA && limit <= max_uA) {
- rv = regmap_update_bits(map, rdesc->regA,
+ return regmap_update_bits(map, rdesc->regA,
MAX77650_REGULATOR_CURR_LIM_MASK,
MAX77650_REGULATOR_CURR_LIM_SHIFT(i));
- if (rv)
- return rv;
}
}

--
2.17.1

2019-02-22 09:17:26

by Bartosz Golaszewski

Subject: Re: [PATCH] regulator: max77650: Fix set_current_limit implementation

pt., 22 lut 2019 o 10:09 Axel Lin <[email protected]> napisał(a):
>
> Current code always return error, fix it.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/regulator/max77650-regulator.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/max77650-regulator.c b/drivers/regulator/max77650-regulator.c
> index 411912d5278b..a1af414db751 100644
> --- a/drivers/regulator/max77650-regulator.c
> +++ b/drivers/regulator/max77650-regulator.c
> @@ -243,7 +243,7 @@ static int max77650_regulator_set_current_limit(struct regulator_dev *rdev,
> {
> struct max77650_regulator_desc *rdesc;
> struct regmap *map;
> - int rv, i, limit;
> + int i, limit;
>
> rdesc = rdev_get_drvdata(rdev);
> map = rdev_get_regmap(rdev);
> @@ -252,11 +252,9 @@ static int max77650_regulator_set_current_limit(struct regulator_dev *rdev,
> limit = max77650_current_limit_table[i];
>
> if (limit >= min_uA && limit <= max_uA) {
> - rv = regmap_update_bits(map, rdesc->regA,
> + return regmap_update_bits(map, rdesc->regA,
> MAX77650_REGULATOR_CURR_LIM_MASK,
> MAX77650_REGULATOR_CURR_LIM_SHIFT(i));
> - if (rv)
> - return rv;
> }
> }
>
> --
> 2.17.1
>

Thanks for spotting that!

Reviewed-by: Bartosz Golaszewski <[email protected]>