Hi all,
I was working with some queues the other day and I noticed that there
was a list_add_tail() function in list.h, but no list_del_head()
function. This struck me as a little odd, so I went ahead and
implemented one in order to complete full queue functionality. The
patch below was generated against pristine 2.6.9 kernel.org kernel
sources and is attached to this email.
Please CC me on any replies, as I'm not subscribed to LKML. Thanks :)
Name: Add list_del_head for full queue functionality
Status: Tested
Signed-off-by: Tobias DiPasquale <[email protected]>
--
[ Tobias DiPasquale ]
0x636f6465736c696e67657240676d61696c2e636f6d
On Sat, Nov 20 2004, Tobias DiPasquale wrote:
> Hi all,
>
> I was working with some queues the other day and I noticed that there
> was a list_add_tail() function in list.h, but no list_del_head()
> function. This struck me as a little odd, so I went ahead and
> implemented one in order to complete full queue functionality. The
> patch below was generated against pristine 2.6.9 kernel.org kernel
> sources and is attached to this email.
Generally patches like this have little merrit unless accompanied by
another patch converting several obvious pieces of kernel code to use
it.
Also I find the interface awkward and different from the other list
functions.
entry = list_del_head(list);
would have been much nicer.
--
Jens Axboe
On Mon, 22 Nov 2004 10:20:59 +0100, Jens Axboe <[email protected]> wrote:
> Generally patches like this have little merrit unless accompanied by
> another patch converting several obvious pieces of kernel code to use
> it.
>
> Also I find the interface awkward and different from the other list
> functions.
>
> entry = list_del_head(list);
>
> would have been much nicer.
Ok I'll do both things and resubmit. Thanks for getting back to me :)
--
[ Tobias DiPasquale ]
0x636f6465736c696e67657240676d61696c2e636f6d