2019-05-02 11:48:57

by Colin King

Subject: re: serial: Add Milbeaut serial control

Hi,

Static analysis with Coverity has picked up an issue in commit:

commit ba44dc04300441b47618f9933bf36e75a280e5fe
Author: Sugaya Taichi <[email protected]>
Date: Mon Apr 15 20:31:40 2019 +0900

serial: Add Milbeaut serial control

In function mlb_usio_rx_chars() the u8 status is being bit-wise AND'd
with MLB_USIO_SSR_BRK (which is 1UL << 8) and hence the result is always
false, which looks incorrect to me. Is this intentional?

Colin

2019-05-08 13:31:56

by Sugaya Taichi

Subject: Re: serial: Add Milbeaut serial control

Hi,

Thank you for pointing out.

On 2019/05/02 20:47, Colin Ian King wrote:
> Hi,
>
> Static analysis with Coverity has picked up an issue in commit:
>
> commit ba44dc04300441b47618f9933bf36e75a280e5fe
> Author: Sugaya Taichi <[email protected]>
> Date: Mon Apr 15 20:31:40 2019 +0900
>
> serial: Add Milbeaut serial control
>
> In function mlb_usio_rx_chars() the u8 status is being bit-wise AND'd
> with MLB_USIO_SSR_BRK (which is 1UL << 8) and hence the result is always
> false, which looks incorrect to me. Is this intentional?
>

No. It is always false so should be dropped.
I will send a fixes patch.

Thanks,
Sugaya Taichi

> Colin
>