The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it
depend on SYSFS as it makes no sense to enable this feature without it.
Suggested-by: Masahiro Yamada <[email protected]>
Signed-off-by: Joel Fernandes (Google) <[email protected]>
---
init/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/init/Kconfig b/init/Kconfig
index ce08adf0f637..f27138a8cf28 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -581,6 +581,7 @@ config IKCONFIG_PROC
config IKHEADERS
tristate "Enable kernel headers through /sys/kernel/kheaders.tar.xz"
+ depends on SYSFS
help
This option enables access to the in-kernel headers that are generated during
the build process. These can be used to build eBPF tracing programs,
--
2.21.0.1020.gf2820cf01a-goog
On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google)
<[email protected]> wrote:
>
> The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it
> depend on SYSFS as it makes no sense to enable this feature without it.
And, it also makes no sense to break the feature by 1/3,
then fix it by 3/3.
Why don't you squash this?
>
> Suggested-by: Masahiro Yamada <[email protected]>
> Signed-off-by: Joel Fernandes (Google) <[email protected]>
> ---
> init/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index ce08adf0f637..f27138a8cf28 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -581,6 +581,7 @@ config IKCONFIG_PROC
>
> config IKHEADERS
> tristate "Enable kernel headers through /sys/kernel/kheaders.tar.xz"
> + depends on SYSFS
> help
> This option enables access to the in-kernel headers that are generated during
> the build process. These can be used to build eBPF tracing programs,
> --
> 2.21.0.1020.gf2820cf01a-goog
>
--
Best Regards
Masahiro Yamada
On Sat, May 11, 2019 at 09:52:04AM +0900, Masahiro Yamada wrote:
> On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google)
> <[email protected]> wrote:
> >
> > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it
> > depend on SYSFS as it makes no sense to enable this feature without it.
>
>
> And, it also makes no sense to break the feature by 1/3,
> then fix it by 3/3.
>
>
> Why don't you squash this?
I agree, this belongs in patch 1/3.
On Sat, May 11, 2019 at 08:02:03AM +0200, Greg Kroah-Hartman wrote:
> On Sat, May 11, 2019 at 09:52:04AM +0900, Masahiro Yamada wrote:
> > On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google)
> > <[email protected]> wrote:
> > >
> > > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it
> > > depend on SYSFS as it makes no sense to enable this feature without it.
> >
> >
> > And, it also makes no sense to break the feature by 1/3,
> > then fix it by 3/3.
> >
> >
> > Why don't you squash this?
>
> I agree, this belongs in patch 1/3.
Fine with me. The reason I split it this way is I already had posted 1/3
recently for the driver tree [1], and I did not want to confuse Greg since he
was in the process of picking it up [2].
Anyway, I can resend the series soon with 1/3 and 3/3 squashed unless anyone
applying this is Ok with squashing it in their trees. thanks!
[1] https://lore.kernel.org/patchwork/patch/1070005/
[2] https://lore.kernel.org/patchwork/patch/1070005/#1267273
thanks,
- Joel