2019-09-22 18:48:18

by Andrew Murray

Subject: Re: [PATCH] PCI: tegra: include linux/pinctrl/consumer.h

On Fri, Sep 20, 2019 at 04:55:05PM +0200, Arnd Bergmann wrote:
> Without this, we can run into a build failure:
>
> drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration]
>
> Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> Signed-off-by: Arnd Bergmann <[email protected]>

Thanks for this. Another fix for this came in earlier today:

https://patchwork.ozlabs.org/patch/1165139/

Reviewed-by: Andrew Murray <[email protected]>

Thanks,

Andrew Murray

> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 09ed8e473cff..f89f5acee72d 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -22,6 +22,7 @@
> #include <linux/of_pci.h>
> #include <linux/pci.h>
> #include <linux/phy/phy.h>
> +#include <linux/pinctrl/consumer.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/random.h>
> --
> 2.20.0
>

2019-09-22 18:49:08

by Lorenzo Pieralisi

Subject: Re: [PATCH] PCI: tegra: include linux/pinctrl/consumer.h

On Fri, Sep 20, 2019 at 04:07:14PM +0100, Andrew Murray wrote:
> On Fri, Sep 20, 2019 at 04:55:05PM +0200, Arnd Bergmann wrote:
> > Without this, we can run into a build failure:
> >
> > drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration]
> >
> > Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> > Signed-off-by: Arnd Bergmann <[email protected]>
>
> Thanks for this. Another fix for this came in earlier today:
>
> https://patchwork.ozlabs.org/patch/1165139/

I have applied it since it came in earlier.

Thanks,
Lorenzo

> Reviewed-by: Andrew Murray <[email protected]>
>
> Thanks,
>
> Andrew Murray
>
> > ---
> > drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> > index 09ed8e473cff..f89f5acee72d 100644
> > --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> > @@ -22,6 +22,7 @@
> > #include <linux/of_pci.h>
> > #include <linux/pci.h>
> > #include <linux/phy/phy.h>
> > +#include <linux/pinctrl/consumer.h>
> > #include <linux/platform_device.h>
> > #include <linux/pm_runtime.h>
> > #include <linux/random.h>
> > --
> > 2.20.0
> >