2019-11-13 01:33:41

by James Qian Wang

Subject: [PATCH] drm/komeda: Fix komeda driver build error

Fix the build errors lead by

'commit 4039f0293bbd ("drm/komeda: Add option to print WARN- and INFO-level IRQ events")'

Signed-off-by: james qian wang (Arm Technology China) <[email protected]>
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
index 15f52e304c08..d406a4d83352 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
@@ -51,12 +51,12 @@

#define KOMEDA_WARN_EVENTS KOMEDA_ERR_CSCE

-#define KOMEDA_INFO_EVENTS ({0 \
+#define KOMEDA_INFO_EVENTS (0 \
| KOMEDA_EVENT_VSYNC \
| KOMEDA_EVENT_FLIP \
| KOMEDA_EVENT_EOW \
| KOMEDA_EVENT_MODE \
- })
+ )

/* malidp device id */
enum {
--
2.20.1

2019-11-13 08:06:50

by Daniel Vetter

Subject: Re: [PATCH] drm/komeda: Fix komeda driver build error

On Wed, Nov 13, 2019 at 2:32 AM james qian wang (Arm Technology China)
<[email protected]> wrote:
>
> Fix the build errors lead by
>
> 'commit 4039f0293bbd ("drm/komeda: Add option to print WARN- and INFO-level IRQ events")'
>
> Signed-off-by: james qian wang (Arm Technology China) <[email protected]>

Reviewed-by: Daniel Vetter <[email protected]>

Please also re-enable the komde driver (including all options) in all
the defconfigs in drm-rerere. And maybe type some scripts to compile
test before pushing :-)
-Daniel

> ---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> index 15f52e304c08..d406a4d83352 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> @@ -51,12 +51,12 @@
>
> #define KOMEDA_WARN_EVENTS KOMEDA_ERR_CSCE
>
> -#define KOMEDA_INFO_EVENTS ({0 \
> +#define KOMEDA_INFO_EVENTS (0 \
> | KOMEDA_EVENT_VSYNC \
> | KOMEDA_EVENT_FLIP \
> | KOMEDA_EVENT_EOW \
> | KOMEDA_EVENT_MODE \
> - })
> + )
>
> /* malidp device id */
> enum {
> --
> 2.20.1
>


--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch