On Wed, Nov 20, 2019 at 09:38:38PM +0800, Krzysztof Kozlowski wrote:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> $ sed -e 's/^ /\t/' -i */Kconfig
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
No particular objections but I wonder if this would be better sent to
[email protected] .
Daniel.
> ---
> drivers/video/backlight/Kconfig | 8 ++--
> drivers/video/console/Kconfig | 76 ++++++++++++++++-----------------
> 2 files changed, 42 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 403707a3e503..95e2000c1491 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -9,7 +9,7 @@ menu "Backlight & LCD device support"
> # LCD
> #
> config LCD_CLASS_DEVICE
> - tristate "Lowlevel LCD controls"
> + tristate "Lowlevel LCD controls"
> help
> This framework adds support for low-level control of LCD.
> Some framebuffer devices connect to platform-specific LCD modules
> @@ -141,10 +141,10 @@ endif # LCD_CLASS_DEVICE
> # Backlight
> #
> config BACKLIGHT_CLASS_DEVICE
> - tristate "Lowlevel Backlight controls"
> + tristate "Lowlevel Backlight controls"
> help
> This framework adds support for low-level control of the LCD
> - backlight. This includes support for brightness and power.
> + backlight. This includes support for brightness and power.
>
> To have support for your specific LCD panel you will have to
> select the proper drivers which depend on this option.
> @@ -272,7 +272,7 @@ config BACKLIGHT_APPLE
> tristate "Apple Backlight Driver"
> depends on X86 && ACPI
> help
> - If you have an Intel-based Apple say Y to enable a driver for its
> + If you have an Intel-based Apple say Y to enable a driver for its
> backlight.
>
> config BACKLIGHT_TOSA
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index c10e17fb9a9a..ac3a28c08f78 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -27,7 +27,7 @@ config VGACON_SOFT_SCROLLBACK
> depends on VGA_CONSOLE
> default n
> help
> - The scrollback buffer of the standard VGA console is located in
> + The scrollback buffer of the standard VGA console is located in
> the VGA RAM. The size of this RAM is fixed and is quite small.
> If you require a larger scrollback buffer, this can be placed in
> System RAM which is dynamically allocated during initialization.
> @@ -84,12 +84,12 @@ config MDA_CONSOLE
> If unsure, say N.
>
> config SGI_NEWPORT_CONSOLE
> - tristate "SGI Newport Console support"
> + tristate "SGI Newport Console support"
> depends on SGI_IP22 && HAS_IOMEM
> - select FONT_SUPPORT
> - help
> - Say Y here if you want the console on the Newport aka XL graphics
> - card of your Indy. Most people say Y here.
> + select FONT_SUPPORT
> + help
> + Say Y here if you want the console on the Newport aka XL graphics
> + card of your Indy. Most people say Y here.
>
> config DUMMY_CONSOLE
> bool
> @@ -97,24 +97,24 @@ config DUMMY_CONSOLE
> default y
>
> config DUMMY_CONSOLE_COLUMNS
> - int "Initial number of console screen columns"
> - depends on DUMMY_CONSOLE && !ARM
> - default 160 if PARISC
> - default 80
> - help
> - On PA-RISC, the default value is 160, which should fit a 1280x1024
> - monitor.
> - Select 80 if you use a 640x480 resolution by default.
> + int "Initial number of console screen columns"
> + depends on DUMMY_CONSOLE && !ARM
> + default 160 if PARISC
> + default 80
> + help
> + On PA-RISC, the default value is 160, which should fit a 1280x1024
> + monitor.
> + Select 80 if you use a 640x480 resolution by default.
>
> config DUMMY_CONSOLE_ROWS
> - int "Initial number of console screen rows"
> - depends on DUMMY_CONSOLE && !ARM
> - default 64 if PARISC
> - default 25
> - help
> - On PA-RISC, the default value is 64, which should fit a 1280x1024
> - monitor.
> - Select 25 if you use a 640x480 resolution by default.
> + int "Initial number of console screen rows"
> + depends on DUMMY_CONSOLE && !ARM
> + default 64 if PARISC
> + default 25
> + help
> + On PA-RISC, the default value is 64, which should fit a 1280x1024
> + monitor.
> + Select 25 if you use a 640x480 resolution by default.
>
> config FRAMEBUFFER_CONSOLE
> bool "Framebuffer Console support"
> @@ -130,11 +130,11 @@ config FRAMEBUFFER_CONSOLE_DETECT_PRIMARY
> depends on FRAMEBUFFER_CONSOLE
> default n
> ---help---
> - If this option is selected, the framebuffer console will
> - automatically select the primary display device (if the architecture
> + If this option is selected, the framebuffer console will
> + automatically select the primary display device (if the architecture
> supports this feature). Otherwise, the framebuffer console will
> - always select the first framebuffer driver that is loaded. The latter
> - is the default behavior.
> + always select the first framebuffer driver that is loaded. The latter
> + is the default behavior.
>
> You can always override the automatic selection of the primary device
> by using the fbcon=map: boot option.
> @@ -145,11 +145,11 @@ config FRAMEBUFFER_CONSOLE_ROTATION
> bool "Framebuffer Console Rotation"
> depends on FRAMEBUFFER_CONSOLE
> help
> - Enable display rotation for the framebuffer console. This is done
> - in software and may be significantly slower than a normally oriented
> - display. Note that the rotation is done at the console level only
> - such that other users of the framebuffer will remain normally
> - oriented.
> + Enable display rotation for the framebuffer console. This is done
> + in software and may be significantly slower than a normally oriented
> + display. Note that the rotation is done at the console level only
> + such that other users of the framebuffer will remain normally
> + oriented.
>
> config FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER
> bool "Framebuffer Console Deferred Takeover"
> @@ -163,14 +163,14 @@ config FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER
> black screen as soon as fbcon loads.
>
> config STI_CONSOLE
> - bool "STI text console"
> + bool "STI text console"
> depends on PARISC && HAS_IOMEM
> - select FONT_SUPPORT
> - default y
> - help
> - The STI console is the builtin display/keyboard on HP-PARISC
> - machines. Say Y here to build support for it into your kernel.
> - The alternative is to use your primary serial port as a console.
> + select FONT_SUPPORT
> + default y
> + help
> + The STI console is the builtin display/keyboard on HP-PARISC
> + machines. Say Y here to build support for it into your kernel.
> + The alternative is to use your primary serial port as a console.
>
> endmenu
>
> --
> 2.17.1
>
On Wed, Nov 20, 2019 at 08:45:46AM -0500, Daniel Thompson wrote:
> On Wed, Nov 20, 2019 at 09:38:38PM +0800, Krzysztof Kozlowski wrote:
> > Adjust indentation from spaces to tab (+optional two spaces) as in
> > coding style with command like:
> > $ sed -e 's/^ /\t/' -i */Kconfig
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> No particular objections but I wonder if this would be better sent to
> [email protected] .
Thanks for feedback.
I sent to trivial and kernel-janitors my previous version of this
patchset which was not split per-subsystem and there was no feedback.
Few other patches already came through maintainers. If there will be no
reply, I'll send next version through trivial.
Best regards,
Krzysztof
[ added Jiri to Cc: ]
On 11/20/19 2:50 PM, Krzysztof Kozlowski wrote:
> On Wed, Nov 20, 2019 at 08:45:46AM -0500, Daniel Thompson wrote:
>> On Wed, Nov 20, 2019 at 09:38:38PM +0800, Krzysztof Kozlowski wrote:
>>> Adjust indentation from spaces to tab (+optional two spaces) as in
>>> coding style with command like:
>>> $ sed -e 's/^ /\t/' -i */Kconfig
>>>
>>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>
>> No particular objections but I wonder if this would be better sent to
>> [email protected] .
>
> Thanks for feedback.
>
> I sent to trivial and kernel-janitors my previous version of this
> patchset which was not split per-subsystem and there was no feedback.
> Few other patches already came through maintainers. If there will be no
> reply, I'll send next version through trivial.
If anyone wants to merge it through backlight or trivial tree:
Acked-by: Bartlomiej Zolnierkiewicz <[email protected]>
Otherwise I'll queue this through drm-misc tree for v5.6.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics