2020-03-18 03:43:56

by brookxu.cn

Subject: [PATCH] mm: Fix a comment typo

Signed-off-by: Chunguang Xu <[email protected]>

---
 mm/page-writeback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 2caf780..2acf754 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1271,7 +1271,7 @@ static void wb_update_dirty_ratelimit(struct dirty_throttle_control *dtc,
      */
 
     /*
-     * dirty_ratelimit will follow balanced_dirty_ratelimit iff
+     * dirty_ratelimit will follow balanced_dirty_ratelimit if
      * task_ratelimit is on the same side of dirty_ratelimit, too.
      * For example, when
      * - dirty_ratelimit > balanced_dirty_ratelimit
--
1.8.3.1

2020-03-18 03:59:48

by James Bottomley

Subject: Re: [PATCH] mm: Fix a comment typo

On Wed, 2020-03-18 at 11:42 +0800, brookxu wrote:
> Signed-off-by: Chunguang Xu <[email protected]>
>
> ---
> mm/page-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 2caf780..2acf754 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -1271,7 +1271,7 @@ static void wb_update_dirty_ratelimit(struct
> dirty_throttle_control *dtc,
> */
>
> /*
> - * dirty_ratelimit will follow balanced_dirty_ratelimit iff
> + * dirty_ratelimit will follow balanced_dirty_ratelimit if

Are you sure it's a mistake? iff means if and only if which would be
reasonable unless the condition is only implies.

James

2020-03-18 04:28:43

by brookxu.cn

Subject: Re: [PATCH] mm: Fix a comment typo

Thank you very much for your reply, it should be my misunderstanding, thanks again~

James Bottomley wrote on 2020/3/18 11:59:
> On Wed, 2020-03-18 at 11:42 +0800, brookxu wrote:
>> Signed-off-by: Chunguang Xu <[email protected]>
>>
>> ---
>> mm/page-writeback.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
>> index 2caf780..2acf754 100644
>> --- a/mm/page-writeback.c
>> +++ b/mm/page-writeback.c
>> @@ -1271,7 +1271,7 @@ static void wb_update_dirty_ratelimit(struct
>> dirty_throttle_control *dtc,
>> */
>>
>> /*
>> - * dirty_ratelimit will follow balanced_dirty_ratelimit iff
>> + * dirty_ratelimit will follow balanced_dirty_ratelimit if
> Are you sure it's a mistake? iff means if and only if which would be
> reasonable unless the condition is only implies.
>
> James
>