2020-04-23 07:24:12

by Zou Wei

Subject: [PATCH -next] qed: Make ll2_cbs static

Fix the following sparse warning:

drivers/net/ethernet/qlogic/qed/qed_ll2.c:2334:20: warning: symbol 'll2_cbs'
was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
index 037e597..4afd857 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
@@ -2331,7 +2331,7 @@ static void qed_ll2_register_cb_ops(struct qed_dev *cdev,
cdev->ll2->cb_cookie = cookie;
}

-struct qed_ll2_cbs ll2_cbs = {
+static struct qed_ll2_cbs ll2_cbs = {
.rx_comp_cb = &qed_ll2b_complete_rx_packet,
.rx_release_cb = &qed_ll2b_release_rx_packet,
.tx_comp_cb = &qed_ll2b_complete_tx_packet,
--
2.6.2

2020-04-23 07:45:57

by Michal Kalderon

Subject: RE: [EXT] [PATCH -next] qed: Make ll2_cbs static

> From: Zou Wei <[email protected]>
> Sent: Thursday, April 23, 2020 10:28 AM
>
> ----------------------------------------------------------------------
> Fix the following sparse warning:
>
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:2334:20: warning: symbol 'll2_cbs'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> index 037e597..4afd857 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> @@ -2331,7 +2331,7 @@ static void qed_ll2_register_cb_ops(struct qed_dev
> *cdev,
> cdev->ll2->cb_cookie = cookie;
> }
>
> -struct qed_ll2_cbs ll2_cbs = {
> +static struct qed_ll2_cbs ll2_cbs = {
> .rx_comp_cb = &qed_ll2b_complete_rx_packet,
> .rx_release_cb = &qed_ll2b_release_rx_packet,
> .tx_comp_cb = &qed_ll2b_complete_tx_packet,
> --
> 2.6.2

Thanks,?

Acked-by: Michal Kalderon?<[email protected]>

2020-04-23 22:56:54

by David Miller

Subject: Re: [PATCH -next] qed: Make ll2_cbs static

From: Zou Wei <[email protected]>
Date: Thu, 23 Apr 2020 15:27:40 +0800

> Fix the following sparse warning:
>
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:2334:20: warning: symbol 'll2_cbs'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Applied.