Fix the following warning:
sound/soc/sof/imx/imx8m.c:95:20: warning:
symbol 'imx8m_dsp_ops' was not declared. Should it be static?
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: ChenTao <[email protected]>
---
sound/soc/sof/imx/imx8m.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sof/imx/imx8m.c b/sound/soc/sof/imx/imx8m.c
index 07451ba4efae..1a5b0f9ebac1 100644
--- a/sound/soc/sof/imx/imx8m.c
+++ b/sound/soc/sof/imx/imx8m.c
@@ -92,7 +92,7 @@ static void imx8m_dsp_handle_request(struct imx_dsp_ipc *ipc)
snd_sof_ipc_msgs_rx(priv->sdev);
}
-struct imx_dsp_ops imx8m_dsp_ops = {
+static struct imx_dsp_ops imx8m_dsp_ops = {
.handle_reply = imx8m_dsp_handle_reply,
.handle_request = imx8m_dsp_handle_request,
};
--
2.22.0
Hi,
[+Daniel]
On Sat, 25 Apr 2020, ChenTao wrote:
> Fix the following warning:
>
> sound/soc/sof/imx/imx8m.c:95:20: warning:
> symbol 'imx8m_dsp_ops' was not declared. Should it be static?
yes, this was missed in the initial version of this driver. Ok to go with
this:
Acked-by: Kai Vehmanen <[email protected]>
You did not send a copy of the patch to Mark Brown ([email protected]).
Can you resend with him in the loop, so he can pick the patch up to ALSA
ASoC tree. Also please copy the ALSA list ([email protected]).
Br, Kai
On Sat, Apr 25, 2020 at 11:03 AM ChenTao <[email protected]> wrote:
>
> Fix the following warning:
>
> sound/soc/sof/imx/imx8m.c:95:20: warning:
> symbol 'imx8m_dsp_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: ChenTao <[email protected]>
Reviewed-by: Daniel Baluta <[email protected]>
Can you please resend (picking Acked-by/Reviewed-by tags) and
as Kai said add:
To: Mark Brown ([email protected]
Cc: [email protected]
Thanks a lot, i will resend v2 and add Mark Brown [email protected]
[email protected]
On 2020/4/29 0:42, Daniel Baluta wrote:
> On Sat, Apr 25, 2020 at 11:03 AM ChenTao <[email protected]> wrote:
>> Fix the following warning:
>>
>> sound/soc/sof/imx/imx8m.c:95:20: warning:
>> symbol 'imx8m_dsp_ops' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: ChenTao <[email protected]>
> Reviewed-by: Daniel Baluta <[email protected]>
>
> Can you please resend (picking Acked-by/Reviewed-by tags) and
> as Kai said add:
>
> To: Mark Brown ([email protected]
> Cc: [email protected]
> .