2020-05-04 08:31:52

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH 0/3] Tegra194 HW Fixes

On Mon, 04 May 2020 10:16:13 +0200,
Sameer Pujar wrote:
>
> This series proposes SW workarounds for Tegra194 HDA HW bugs.
> Following are the two issues seen:
> 1. GCAP register does not reflect true capability.
> The actual number of SDO lines is "4", where as it reflects "2".
> 2. With 4 SDO line configuration playback fails for,
> 44.1K/48K, 2-channel, 16-bps audio stream.
>
> After fixing [1], issue [2] is uncovered.
> As per recommendation by Tegra HW team the workarounds are pushed.
>
> Testing done
> ============
> * Verify GCAP register after registering HDA sound card
> * Verify audio playback for 44.1K/48K, 2-channel, 16-bps.
>
> Sameer Pujar (3):
> ALSA: hda/tegra: correct number of SDO lines for Tegra194
> ALSA: hda: add member to store ratio for stripe control
> ALSA: hda/tegra: workaround playback failure on Tegra194

Through a quick glance, all changes look good.

Is the device already in market, i.e. it had hit users? If yes, I'm
going to merge for 5.7, otherwise for 5.8.


thanks,

Takashi