2006-03-09 03:05:52

by Dave Jones

[permalink] [raw]
Subject: Remove redundant check from autofs4_put_super

We have to have a valid sbi here, or we'd have oopsed already.
(There's a dereference of sbi->catatonic a few lines above)

Coverity #740
Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6/fs/autofs4/inode.c~ 2006-03-08 22:02:53.000000000 -0500
+++ linux-2.6/fs/autofs4/inode.c 2006-03-08 22:03:47.000000000 -0500
@@ -145,8 +145,7 @@ static void autofs4_put_super(struct sup
autofs4_catatonic_mode(sbi); /* Free wait queues, close pipe */

/* Clean up and release dangling references */
- if (sbi)
- autofs4_force_release(sbi);
+ autofs4_force_release(sbi);

kfree(sbi);


--
http://www.codemonkey.org.uk