2020-05-24 16:13:27

by Colin King

Subject: [PATCH][next] loop: remove redundant assignment to variable error

From: Colin Ian King <[email protected]>

The variable error is being assigned a value that is never
read so the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/block/loop.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index c20d01c08e5c..060da16b3743 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1136,8 +1136,6 @@ static int loop_configure(struct loop_device *lo, fmode_t mode,
if (error)
goto out_unlock;

- error = 0;
-
set_device_ro(bdev, (lo->lo_flags & LO_FLAGS_READ_ONLY) != 0);

lo->use_dio = lo->lo_flags & LO_FLAGS_DIRECT_IO;
--
2.25.1

2020-05-24 16:48:15

by Jens Axboe

Subject: Re: [PATCH][next] loop: remove redundant assignment to variable error

On 5/24/20 10:10 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable error is being assigned a value that is never
> read so the assignment is redundant and can be removed.

Plus, by definition, we already know that error is zero at the
time of assignment.

--
Jens Axboe