2020-07-22 02:32:08

by Guenter Roeck

Subject: [PATCH -next] scsi: lpfc: Add dependency on CPU_FREQ

Since commit 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for
latency improvment"), the lpfc driver depends on CPUFREQ. Without it,
builds fail with

drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_init_idle_stat_hb':
drivers/scsi/lpfc/lpfc_sli.c:7329:26: error:
implicit declaration of function 'get_cpu_idle_time'

Add the missing dependency.

Fixes: 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for latency improvment")
Cc: Dick Kennedy <[email protected]>
Cc: James Smart <[email protected]>
Signed-off-by: Guenter Roeck <[email protected]>
---
drivers/scsi/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 571473a58f98..701b61ec76ee 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1154,6 +1154,7 @@ source "drivers/scsi/qedf/Kconfig"
config SCSI_LPFC
tristate "Emulex LightPulse Fibre Channel Support"
depends on PCI && SCSI
+ depends on CPU_FREQ
depends on SCSI_FC_ATTRS
depends on NVME_TARGET_FC || NVME_TARGET_FC=n
depends on NVME_FC || NVME_FC=n
--
2.17.1

2020-07-22 16:14:16

by James Smart

Subject: Re: [PATCH -next] scsi: lpfc: Add dependency on CPU_FREQ

On 7/21/2020 7:30 PM, Guenter Roeck wrote:
> Since commit 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for
> latency improvment"), the lpfc driver depends on CPUFREQ. Without it,
> builds fail with
>
> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_init_idle_stat_hb':
> drivers/scsi/lpfc/lpfc_sli.c:7329:26: error:
> implicit declaration of function 'get_cpu_idle_time'
>
> Add the missing dependency.
>
> Fixes: 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for latency improvment")
> Cc: Dick Kennedy <[email protected]>
> Cc: James Smart <[email protected]>
> Signed-off-by: Guenter Roeck <[email protected]>
> ---
> drivers/scsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 571473a58f98..701b61ec76ee 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1154,6 +1154,7 @@ source "drivers/scsi/qedf/Kconfig"
> config SCSI_LPFC
> tristate "Emulex LightPulse Fibre Channel Support"
> depends on PCI && SCSI
> + depends on CPU_FREQ
> depends on SCSI_FC_ATTRS
> depends on NVME_TARGET_FC || NVME_TARGET_FC=n
> depends on NVME_FC || NVME_FC=n

Reviewed-by:  James Smart <[email protected]>

-- james

2020-07-25 02:54:27

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: lpfc: Add dependency on CPU_FREQ

On Tue, 21 Jul 2020 19:30:27 -0700, Guenter Roeck wrote:

> Since commit 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for
> latency improvment"), the lpfc driver depends on CPUFREQ. Without it,
> builds fail with
>
> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_init_idle_stat_hb':
> drivers/scsi/lpfc/lpfc_sli.c:7329:26: error:
> implicit declaration of function 'get_cpu_idle_time'
>
> [...]

Applied to 5.9/scsi-queue, thanks!

[1/1] scsi: lpfc: Add dependency on CPU_FREQ
https://git.kernel.org/mkp/scsi/c/e3d2bf6505dd

--
Martin K. Petersen Oracle Linux Engineering