2020-08-09 06:20:28

by Lukas Bulwahn

Subject: [PATCH] dma-buf.rst: repair length of title underline

With commit 72b6ede73623 ("dma-buf.rst: Document why indefinite fences are
a bad idea"), document generation warns:

Documentation/driver-api/dma-buf.rst:182: \
WARNING: Title underline too short.

Repair length of title underline to remove warning.

Fixes: 72b6ede73623 ("dma-buf.rst: Document why indefinite fences are a bad idea")
Signed-off-by: Lukas Bulwahn <[email protected]>
---
Daniel, please pick this minor non-urgent fix to your new documentation.

Documentation/driver-api/dma-buf.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst
index 100bfd227265..13ea0cc0a3fa 100644
--- a/Documentation/driver-api/dma-buf.rst
+++ b/Documentation/driver-api/dma-buf.rst
@@ -179,7 +179,7 @@ DMA Fence uABI/Sync File
:internal:

Indefinite DMA Fences
-~~~~~~~~~~~~~~~~~~~~
+~~~~~~~~~~~~~~~~~~~~~

At various times &dma_fence with an indefinite time until dma_fence_wait()
finishes have been proposed. Examples include:
--
2.17.1

2020-08-10 11:26:51

by Christian König

Subject: Re: [PATCH] dma-buf.rst: repair length of title underline

Am 09.08.20 um 08:17 schrieb Lukas Bulwahn:
> With commit 72b6ede73623 ("dma-buf.rst: Document why indefinite fences are
> a bad idea"), document generation warns:
>
> Documentation/driver-api/dma-buf.rst:182: \
> WARNING: Title underline too short.
>
> Repair length of title underline to remove warning.
>
> Fixes: 72b6ede73623 ("dma-buf.rst: Document why indefinite fences are a bad idea")
> Signed-off-by: Lukas Bulwahn <[email protected]>

Acked-by: Christian König <[email protected]>

Should I pick it up into drm-misc-next?

> ---
> Daniel, please pick this minor non-urgent fix to your new documentation.
>
> Documentation/driver-api/dma-buf.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst
> index 100bfd227265..13ea0cc0a3fa 100644
> --- a/Documentation/driver-api/dma-buf.rst
> +++ b/Documentation/driver-api/dma-buf.rst
> @@ -179,7 +179,7 @@ DMA Fence uABI/Sync File
> :internal:
>
> Indefinite DMA Fences
> -~~~~~~~~~~~~~~~~~~~~
> +~~~~~~~~~~~~~~~~~~~~~
>
> At various times &dma_fence with an indefinite time until dma_fence_wait()
> finishes have been proposed. Examples include:

2020-08-10 13:07:22

by Daniel Vetter

Subject: Re: [PATCH] dma-buf.rst: repair length of title underline

On Mon, Aug 10, 2020 at 01:25:40PM +0200, Christian K?nig wrote:
> Am 09.08.20 um 08:17 schrieb Lukas Bulwahn:
> > With commit 72b6ede73623 ("dma-buf.rst: Document why indefinite fences are
> > a bad idea"), document generation warns:
> >
> > Documentation/driver-api/dma-buf.rst:182: \
> > WARNING: Title underline too short.
> >
> > Repair length of title underline to remove warning.
> >
> > Fixes: 72b6ede73623 ("dma-buf.rst: Document why indefinite fences are a bad idea")
> > Signed-off-by: Lukas Bulwahn <[email protected]>
>
> Acked-by: Christian K?nig <[email protected]>
>
> Should I pick it up into drm-misc-next?

Yes please. For the future if you need to check if someone has commit
rights and can push themselves:

https://people.freedesktop.org/~seanpaul/whomisc.html

Yeah with gitlab this would all be a bit more reasonable, but we get by
meanwhile :-)

Cheers, Daniel
>
> > ---
> > Daniel, please pick this minor non-urgent fix to your new documentation.
> >
> > Documentation/driver-api/dma-buf.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst
> > index 100bfd227265..13ea0cc0a3fa 100644
> > --- a/Documentation/driver-api/dma-buf.rst
> > +++ b/Documentation/driver-api/dma-buf.rst
> > @@ -179,7 +179,7 @@ DMA Fence uABI/Sync File
> > :internal:
> > Indefinite DMA Fences
> > -~~~~~~~~~~~~~~~~~~~~
> > +~~~~~~~~~~~~~~~~~~~~~
> > At various times &dma_fence with an indefinite time until dma_fence_wait()
> > finishes have been proposed. Examples include:
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch