2020-08-26 06:55:08

by Yue Haibing

Subject: [PATCH] net: cdc_ncm: Fix build error

If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails:

drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to `usbnet_cdc_update_filter'

Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this.

Reported-by: Hulk Robot <[email protected]>
Fixes: e10dcb1b6ba7 ("net: cdc_ncm: hook into set_rx_mode to admit multicast traffic")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/usb/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index a7fbc3ccd29e..c7bcfca7d70b 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -252,6 +252,7 @@ config USB_NET_CDC_EEM
config USB_NET_CDC_NCM
tristate "CDC NCM support"
depends on USB_USBNET
+ select USB_NET_CDCETHER
default y
help
This driver provides support for CDC NCM (Network Control Model
--
2.17.1

2020-08-26 07:17:15

by Bjørn Mork

Subject: Re: [PATCH] net: cdc_ncm: Fix build error

YueHaibing <[email protected]> writes:

> If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails:
>
> drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to `usbnet_cdc_update_filter'
>
> Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this.

Ouch. For some reason I assumed that was always selected with usbnet.
Thanks for fixing.



Bjørn

2020-08-26 14:39:24

by David Miller

Subject: Re: [PATCH] net: cdc_ncm: Fix build error

From: YueHaibing <[email protected]>
Date: Wed, 26 Aug 2020 14:52:31 +0800

> If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails:
>
> drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to `usbnet_cdc_update_filter'
>
> Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this.
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: e10dcb1b6ba7 ("net: cdc_ncm: hook into set_rx_mode to admit multicast traffic")
> Signed-off-by: YueHaibing <[email protected]>

Applied, thank you.