Currently the Keystone driver can only be compile-tested on ARM, but
this restriction seems unnecessary. Get rid of it to increase test
coverage.
Build-tested on x86 with allyesconfig.
Signed-off-by: Alex Dewar <[email protected]>
---
drivers/pci/controller/dwc/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 044a3761c44f..ca36691314ed 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -107,7 +107,7 @@ config PCI_KEYSTONE
config PCI_KEYSTONE_HOST
bool "PCI Keystone Host Mode"
- depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
+ depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
depends on PCI_MSI_IRQ_DOMAIN
select PCIE_DW_HOST
select PCI_KEYSTONE
@@ -119,7 +119,7 @@ config PCI_KEYSTONE_HOST
config PCI_KEYSTONE_EP
bool "PCI Keystone Endpoint Mode"
- depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
+ depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
depends on PCI_ENDPOINT
select PCIE_DW_EP
select PCI_KEYSTONE
--
2.28.0
On Fri, 4 Sep 2020 at 20:56, Alex Dewar <[email protected]> wrote:
>
> Currently the Keystone driver can only be compile-tested on ARM, but
> this restriction seems unnecessary. Get rid of it to increase test
> coverage.
>
> Build-tested on x86 with allyesconfig.
You should at least build it on x86_64, powerpc and MIPS. These are
widely available (e.g. in most of distros, or here:
https://mirrors.edge.kernel.org/pub/tools/crosstool/). Useful is also
riscv and sh (specially sh lacks certain headers/features).
Best regards,
Krzysztof
On Sun, Sep 06, 2020 at 02:19:44PM +0200, Krzysztof Kozlowski wrote:
> On Fri, 4 Sep 2020 at 20:56, Alex Dewar <[email protected]> wrote:
> >
> > Currently the Keystone driver can only be compile-tested on ARM, but
> > this restriction seems unnecessary. Get rid of it to increase test
> > coverage.
> >
> > Build-tested on x86 with allyesconfig.
>
> You should at least build it on x86_64, powerpc and MIPS. These are
> widely available (e.g. in most of distros, or here:
> https://mirrors.edge.kernel.org/pub/tools/crosstool/). Useful is also
> riscv and sh (specially sh lacks certain headers/features).
Good suggestion. I've built it on x86, ppc, mips and riscv. sh wouldn't
build because of some kbuild dependency, rather than a compiler error.
I'll send a v2 with an updated commit message.
>
> Best regards,
> Krzysztof
Currently the Keystone driver can only be compile-tested on ARM, but
this restriction seems unnecessary. Get rid of it to increase test
coverage.
Build-tested with allyesconfig on x86, ppc, mips and riscv.
Signed-off-by: Alex Dewar <[email protected]>
---
drivers/pci/controller/dwc/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 044a3761c44f..ca36691314ed 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -107,7 +107,7 @@ config PCI_KEYSTONE
config PCI_KEYSTONE_HOST
bool "PCI Keystone Host Mode"
- depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
+ depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
depends on PCI_MSI_IRQ_DOMAIN
select PCIE_DW_HOST
select PCI_KEYSTONE
@@ -119,7 +119,7 @@ config PCI_KEYSTONE_HOST
config PCI_KEYSTONE_EP
bool "PCI Keystone Endpoint Mode"
- depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
+ depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
depends on PCI_ENDPOINT
select PCIE_DW_EP
select PCI_KEYSTONE
--
2.28.0
On 2020-09-06 20:51, Alex Dewar wrote:
> Currently the Keystone driver can only be compile-tested on ARM, but
> this restriction seems unnecessary. Get rid of it to increase test
> coverage.
Friendly ping?
>
> Build-tested with allyesconfig on x86, ppc, mips and riscv.
>
> Signed-off-by: Alex Dewar <[email protected]>
> ---
> drivers/pci/controller/dwc/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 044a3761c44f..ca36691314ed 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -107,7 +107,7 @@ config PCI_KEYSTONE
>
> config PCI_KEYSTONE_HOST
> bool "PCI Keystone Host Mode"
> - depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
> + depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW_HOST
> select PCI_KEYSTONE
> @@ -119,7 +119,7 @@ config PCI_KEYSTONE_HOST
>
> config PCI_KEYSTONE_EP
> bool "PCI Keystone Endpoint Mode"
> - depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
> + depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
> depends on PCI_ENDPOINT
> select PCIE_DW_EP
> select PCI_KEYSTONE
On Sun, 06 Sep 2020 20:51:27 +0100, Alex Dewar wrote:
> Currently the Keystone driver can only be compile-tested on ARM, but
> this restriction seems unnecessary. Get rid of it to increase test
> coverage.
>
> Build-tested with allyesconfig on x86, ppc, mips and riscv.
>
> Signed-off-by: Alex Dewar <[email protected]>
> ---
> drivers/pci/controller/dwc/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On 30/09/2020 19:21, Rob Herring wrote:
> On Sun, 06 Sep 2020 20:51:27 +0100, Alex Dewar wrote:
>> Currently the Keystone driver can only be compile-tested on ARM, but
>> this restriction seems unnecessary. Get rid of it to increase test
>> coverage.
>>
>> Build-tested with allyesconfig on x86, ppc, mips and riscv.
>>
>> Signed-off-by: Alex Dewar <[email protected]>
>> ---
>> drivers/pci/controller/dwc/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
> Acked-by: Rob Herring <[email protected]>
Ping ping? :-)
On Sun, 6 Sep 2020 20:51:27 +0100, Alex Dewar wrote:
> Currently the Keystone driver can only be compile-tested on ARM, but
> this restriction seems unnecessary. Get rid of it to increase test
> coverage.
>
> Build-tested with allyesconfig on x86, ppc, mips and riscv.
Applied to pci/keystone, thanks!
[1/1] PCI: keystone: Enable compile-testing on !ARM
https://git.kernel.org/lpieralisi/pci/c/476b70b4d1
Thanks,
Lorenzo