2020-10-08 09:36:20

by Fei Shao

Subject: [PATCH] rtc: mt6397: Remove unused member dev

Removing the struct member "dev" in mt6397 RTC driver because it's not
initialized and the only usage is for one debugging message.

Also fixed a typo in the error message.

Signed-off-by: Fei Shao <[email protected]>
---

drivers/rtc/rtc-mt6397.c | 3 ++-
include/linux/mfd/mt6397/rtc.h | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
index f8b1353777ba..1894aded4c85 100644
--- a/drivers/rtc/rtc-mt6397.c
+++ b/drivers/rtc/rtc-mt6397.c
@@ -31,7 +31,8 @@ static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc)
MTK_RTC_POLL_DELAY_US,
MTK_RTC_POLL_TIMEOUT);
if (ret < 0)
- dev_err(rtc->dev, "failed to write WRTGE: %d\n", ret);
+ dev_err(rtc->rtc_dev->dev.parent,
+ "failed to write WRTGR: %d\n", ret);

return ret;
}
diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h
index 66989a16221a..c3748b53bf7d 100644
--- a/include/linux/mfd/mt6397/rtc.h
+++ b/include/linux/mfd/mt6397/rtc.h
@@ -72,7 +72,6 @@ struct mtk_rtc_data {
};

struct mt6397_rtc {
- struct device *dev;
struct rtc_device *rtc_dev;

/* Protect register access from multiple tasks */
--
2.28.0.806.g8561365e88-goog

2020-10-15 17:58:52

by Alexandre Belloni

Subject: Re: [PATCH] rtc: mt6397: Remove unused member dev

On Thu, 8 Oct 2020 17:34:14 +0800, Fei Shao wrote:
> Removing the struct member "dev" in mt6397 RTC driver because it's not
> initialized and the only usage is for one debugging message.
>
> Also fixed a typo in the error message.

Applied, thanks!

[1/1] rtc: mt6397: Remove unused member dev
commit: 770c03e6dabacd5b9f57bba93c4311d32b618640

Best regards,
--
Alexandre Belloni <[email protected]>