Subject: [PATCH] [DOCBOOK] fix segfault in docproc.c

From: Henrik Kretzschmar <[email protected]>

Adds a missing exit, if the file that should be parsed couldn't be opened.
Without it crashes with a segfault, cause the filedescriptor is accessed even if the file could not be opened.
This error happens on 2.6.18-rc4-mm[12] when executing make xmldocs.

Signed-off-by: Henrik Kretzschmar <[email protected]>
---

--- linux-2.6.18-rc4/scripts/basic/docproc.c 2006-06-18 03:49:35.000000000 +0200
+++ linux/scripts/basic/docproc.c 2006-08-18 22:19:48.000000000 +0200
@@ -177,6 +177,7 @@
{
fprintf(stderr, "docproc: ");
perror(real_filename);
+ exit(1);
}
while(fgets(line, MAXLINESZ, fp)) {
char *p;



2006-08-21 20:32:42

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] [DOCBOOK] fix segfault in docproc.c

On Mon, 21 Aug 2006 20:34:29 +0200 Henne wrote:

> From: Henrik Kretzschmar <[email protected]>
>
> Adds a missing exit, if the file that should be parsed couldn't be opened.
> Without it crashes with a segfault, cause the filedescriptor is accessed even if the file could not be opened.
> This error happens on 2.6.18-rc4-mm[12] when executing make xmldocs.
>
> Signed-off-by: Henrik Kretzschmar <[email protected]>

Thanks.

Acked-by: Randy Dunlap <[email protected]>

Could you also update Documentation/DocBook/libata.tmpl to use
drivers/ata/ instead of drivers/scsi/ on the !I and !E lines?


> ---
>
> --- linux-2.6.18-rc4/scripts/basic/docproc.c 2006-06-18 03:49:35.000000000 +0200
> +++ linux/scripts/basic/docproc.c 2006-08-18 22:19:48.000000000 +0200
> @@ -177,6 +177,7 @@
> {
> fprintf(stderr, "docproc: ");
> perror(real_filename);
> + exit(1);
> }
> while(fgets(line, MAXLINESZ, fp)) {
> char *p;
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


---
~Randy