2021-04-09 06:10:39

by Jiapeng Chong

Subject: [PATCH] ASoC: Intel: bytcr_wm5102: remove useless variable

Fix the following gcc warning:

sound/soc/intel/boards/bytcr_wm5102.c:216:40: warning:
‘byt_wm5102_dai_params’ defined but not used.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
sound/soc/intel/boards/bytcr_wm5102.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c
index f38850e..fd584e3 100644
--- a/sound/soc/intel/boards/bytcr_wm5102.c
+++ b/sound/soc/intel/boards/bytcr_wm5102.c
@@ -213,14 +213,6 @@ static int byt_wm5102_init(struct snd_soc_pcm_runtime *runtime)
return 0;
}

-static const struct snd_soc_pcm_stream byt_wm5102_dai_params = {
- .formats = SNDRV_PCM_FMTBIT_S16_LE,
- .rate_min = 48000,
- .rate_max = 48000,
- .channels_min = 2,
- .channels_max = 2,
-};
-
static int byt_wm5102_codec_fixup(struct snd_soc_pcm_runtime *rtd,
struct snd_pcm_hw_params *params)
{
--
1.8.3.1

2021-04-09 16:23:34

by Pierre-Louis Bossart

Subject: Re: [PATCH] ASoC: Intel: bytcr_wm5102: remove useless variable

On 4/9/21 1:08 AM, Jiapeng Chong wrote:
> Fix the following gcc warning:
>
> sound/soc/intel/boards/bytcr_wm5102.c:216:40: warning:
> ‘byt_wm5102_dai_params’ defined but not used.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Thanks for the patch.

Acked-by: Pierre-Louis Bossart <[email protected]>

> ---
> sound/soc/intel/boards/bytcr_wm5102.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c
> index f38850e..fd584e3 100644
> --- a/sound/soc/intel/boards/bytcr_wm5102.c
> +++ b/sound/soc/intel/boards/bytcr_wm5102.c
> @@ -213,14 +213,6 @@ static int byt_wm5102_init(struct snd_soc_pcm_runtime *runtime)
> return 0;
> }
>
> -static const struct snd_soc_pcm_stream byt_wm5102_dai_params = {
> - .formats = SNDRV_PCM_FMTBIT_S16_LE,
> - .rate_min = 48000,
> - .rate_max = 48000,
> - .channels_min = 2,
> - .channels_max = 2,
> -};
> -
> static int byt_wm5102_codec_fixup(struct snd_soc_pcm_runtime *rtd,
> struct snd_pcm_hw_params *params)
> {
>