2021-04-15 13:02:06

by Colin King

[permalink] [raw]
Subject: [PATCH] floppy: remove redundant assignment to variable st

From: Colin Ian King <[email protected]>

The variable st is being assigned a value that is never read and
it is being updated later with a new value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
arch/x86/include/asm/floppy.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/x86/include/asm/floppy.h b/arch/x86/include/asm/floppy.h
index d43717b423cb..6ec3fc969ad5 100644
--- a/arch/x86/include/asm/floppy.h
+++ b/arch/x86/include/asm/floppy.h
@@ -74,7 +74,6 @@ static irqreturn_t floppy_hardint(int irq, void *dev_id)
int lcount;
char *lptr;

- st = 1;
for (lcount = virtual_dma_count, lptr = virtual_dma_addr;
lcount; lcount--, lptr++) {
st = inb(virtual_dma_port + FD_STATUS);
--
2.30.2


2021-04-15 13:23:33

by Willy Tarreau

[permalink] [raw]
Subject: Re: [PATCH] floppy: remove redundant assignment to variable st

On Thu, Apr 15, 2021 at 02:00:20PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable st is being assigned a value that is never read and
> it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Indeed you're right.

Acked-by: Willy Tarreau <[email protected]>

Willy

2021-04-16 07:35:55

by Denis Efremov (Oracle)

[permalink] [raw]
Subject: Re: [PATCH] floppy: remove redundant assignment to variable st

Hi,

On 4/15/21 4:00 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable st is being assigned a value that is never read and
> it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Applied, thanks!

https://github.com/evdenis/linux-floppy/commit/aeec7983d49a5f972df47c742ff8373df15b0d28

> ---
> arch/x86/include/asm/floppy.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/floppy.h b/arch/x86/include/asm/floppy.h
> index d43717b423cb..6ec3fc969ad5 100644
> --- a/arch/x86/include/asm/floppy.h
> +++ b/arch/x86/include/asm/floppy.h
> @@ -74,7 +74,6 @@ static irqreturn_t floppy_hardint(int irq, void *dev_id)
> int lcount;
> char *lptr;
>
> - st = 1;
> for (lcount = virtual_dma_count, lptr = virtual_dma_addr;
> lcount; lcount--, lptr++) {
> st = inb(virtual_dma_port + FD_STATUS);
>

2021-04-16 12:50:34

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] floppy: remove redundant assignment to variable st

On 4/16/21 6:29 AM, Denis Efremov wrote:
> Jens, could you please take this one? I thought to send it to you with other
> cleanup patches in a merge request, but you already applied rest of the
> patches. If you prefer to take it as merge request, it's ok I'll send it
> based on your branch for-5.13/drivers.

I have applied it, thanks.

--
Jens Axboe

2021-04-16 12:51:32

by Denis Efremov (Oracle)

[permalink] [raw]
Subject: Re: [PATCH] floppy: remove redundant assignment to variable st

Jens, could you please take this one? I thought to send it to you with other
cleanup patches in a merge request, but you already applied rest of the
patches. If you prefer to take it as merge request, it's ok I'll send it
based on your branch for-5.13/drivers.

On 4/15/21 4:00 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable st is being assigned a value that is never read and
> it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Denis Efremov <[email protected]>

Thanks,
Denis

> ---
> arch/x86/include/asm/floppy.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/floppy.h b/arch/x86/include/asm/floppy.h
> index d43717b423cb..6ec3fc969ad5 100644
> --- a/arch/x86/include/asm/floppy.h
> +++ b/arch/x86/include/asm/floppy.h
> @@ -74,7 +74,6 @@ static irqreturn_t floppy_hardint(int irq, void *dev_id)
> int lcount;
> char *lptr;
>
> - st = 1;
> for (lcount = virtual_dma_count, lptr = virtual_dma_addr;
> lcount; lcount--, lptr++) {
> st = inb(virtual_dma_port + FD_STATUS);
>