2021-04-23 06:57:31

by Hsin-Yi Wang

Subject: [PATCH] arm64: dts: mt8183: add mediatek,gce-events in mutex

mediatek,gce-events is read by mutex node.

Signed-off-by: Hsin-Yi Wang <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index c5e822b6b77a..cf22d71161e5 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1250,6 +1250,8 @@ mutex: mutex@14016000 {
reg = <0 0x14016000 0 0x1000>;
interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
+ mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
+ <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
};

larb0: larb@14017000 {
--
2.31.1.498.g6c1eba8ee3d-goog

2021-04-23 13:03:18

by Enric Balletbo i Serra

Subject: Re: [PATCH] arm64: dts: mt8183: add mediatek,gce-events in mutex

Hi Hsin-Yi,

Thank you for your patch.

On 23/4/21 8:53, Hsin-Yi Wang wrote:
> mediatek,gce-events is read by mutex node.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>

Although I know this property is used and needed I didn't find documentation
about it. It would be really nice document in the bindings this mediatek property.

In any case this patch LGTM, so

Reviewed-by: Enric Balletbo i Serra <[email protected]>

> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c5e822b6b77a..cf22d71161e5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1250,6 +1250,8 @@ mutex: mutex@14016000 {
> reg = <0 0x14016000 0 0x1000>;
> interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
> power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
> + mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
> + <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
> };
>
> larb0: larb@14017000 {
>

2021-05-03 05:10:58

by Hsin-Yi Wang

Subject: Re: [PATCH] arm64: dts: mt8183: add mediatek,gce-events in mutex

On Fri, Apr 23, 2021 at 9:00 PM Enric Balletbo i Serra
<[email protected]> wrote:
>
> Hi Hsin-Yi,
>
> Thank you for your patch.
>
> On 23/4/21 8:53, Hsin-Yi Wang wrote:
> > mediatek,gce-events is read by mutex node.
> >
> > Signed-off-by: Hsin-Yi Wang <[email protected]>
>
> Although I know this property is used and needed I didn't find documentation
> about it. It would be really nice document in the bindings this mediatek property.
>
> In any case this patch LGTM, so
>
> Reviewed-by: Enric Balletbo i Serra <[email protected]>
>

I added the bindings in v2, thanks.

> > ---
> > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index c5e822b6b77a..cf22d71161e5 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -1250,6 +1250,8 @@ mutex: mutex@14016000 {
> > reg = <0 0x14016000 0 0x1000>;
> > interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
> > power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
> > + mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
> > + <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
> > };
> >
> > larb0: larb@14017000 {
> >